Skip to content

Commit 4d5470f

Browse files
committed
build: remove unnecessary property sets (NFC)
These properties are extraneous. They are never queried, and the `set(...CACHE)` which precedes them will ensure that the value is cached. This should be functionally equivalent.
1 parent 9437adc commit 4d5470f

File tree

2 files changed

+0
-8
lines changed

2 files changed

+0
-8
lines changed

CMakeLists.txt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -117,8 +117,6 @@ endif()
117117

118118
set(SWIFT_ANALYZE_CODE_COVERAGE FALSE CACHE STRING
119119
"Build Swift with code coverage instrumenting enabled [FALSE, NOT-MERGED, MERGED]")
120-
set_property(CACHE SWIFT_ANALYZE_CODE_COVERAGE PROPERTY
121-
STRINGS FALSE "NOT-MERGED" "MERGED")
122120

123121
# SWIFT_VERSION is deliberately /not/ cached so that an existing build directory
124122
# can be reused when a new version of Swift comes out (assuming the user hasn't
@@ -171,8 +169,6 @@ endif()
171169

172170
set(SWIFT_STDLIB_BUILD_TYPE "${CMAKE_BUILD_TYPE}" CACHE STRING
173171
"Build type for the Swift standard library and SDK overlays [Debug, RelWithDebInfo, Release, MinSizeRel]")
174-
set_property(CACHE SWIFT_STDLIB_BUILD_TYPE PROPERTY
175-
STRINGS "Debug" "RelWithDebInfo" "Release" "MinSizeRel")
176172
# Allow the user to specify the standard library CMAKE_MSVC_RUNTIME_LIBRARY
177173
# value. The following values are valid:
178174
# - MultiThreaded (/MT)

cmake/modules/StandaloneOverlay.cmake

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,10 +65,6 @@ option(SWIFT_ENABLE_PARSEABLE_MODULE_INTERFACES
6565
set(SWIFT_STDLIB_BUILD_TYPE "${CMAKE_BUILD_TYPE}" CACHE STRING
6666
"Build type for the Swift standard library and SDK overlays.")
6767

68-
set_property(CACHE SWIFT_STDLIB_BUILD_TYPE PROPERTY
69-
STRINGS
70-
"Debug" "RelWithDebInfo" "Release" "MinSizeRel")
71-
7268
# -----------------------------------------------------------------------------
7369
# Constants
7470

0 commit comments

Comments
 (0)