Skip to content

Commit 4f6489f

Browse files
committed
Fixing comments
Fixing some of the comments in DefaultSettings.cmake and PlatformInfo.cmake. I haven't added any vendor cache files yet, so the comment doesn't point anywhere. Also fixing the reference to the location of the clang resource headers in PlatformInfo.cmake.
1 parent 2a3e6d5 commit 4f6489f

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

Runtimes/Core/cmake/modules/DefaultSettings.cmake

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
# This file is designed to setup reasonable defaults for the various settings so
22
# that configuring a build for a given platform is likely to build
33
# out-of-the-box without customization. This does not mean that it is the only
4-
# way that will work. The config files under `cmake/configs` are build
5-
# configurations that are actually shipping.
4+
# way that will work, or that it represents a shipping configuration.
65

76
set(SwiftCore_ENABLE_BACKTRACING_default OFF) # TODO: enable this by default
87
set(SwiftCore_ENABLE_COMMANDLINE_SUPPORT_default OFF) # TODO: enable this by default

Runtimes/Core/cmake/modules/PlatformInfo.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ endif()
2121
if(NOT SwiftCore_SWIFTC_CLANGIMPORTER_RESOURCE_DIR)
2222
# TODO: We need to separate the concept of compiler resources and the stdlib.
2323
# Compiler-resources in the compiler-resource directory are specific to
24-
# a given compiler. The headers in `lib/clang/include` and
24+
# a given compiler. The headers in `lib/clang/<version>/include` and
2525
# `lib/swift/clang/include` correspond with that specific copy clang and
2626
# should not be mixed. This won't cause modularization issues because
2727
# the one copy of clang should never be looking in the other's resource

0 commit comments

Comments
 (0)