Skip to content

Commit 4f9f6b9

Browse files
committed
Privatize findLHS
It's only used from code completion, but it has a dependency on operator lookup so it's gotta stay a member for now
1 parent 0c54eec commit 4f9f6b9

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

lib/Sema/TypeChecker.h

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -930,6 +930,12 @@ class TypeChecker final {
930930
/// tree.
931931
static Expr *foldSequence(SequenceExpr *expr, DeclContext *dc);
932932

933+
private:
934+
/// Given an pre-folded expression, find LHS from the expression if a binary
935+
/// operator \c name appended to the expression.
936+
static Expr *findLHS(DeclContext *DC, Expr *E, Identifier name);
937+
938+
public:
933939
/// Type check the given expression.
934940
///
935941
/// \param expr The expression to type-check, which will be modified in
@@ -1326,11 +1332,6 @@ class TypeChecker final {
13261332
///
13271333
/// Routines that perform name lookup.
13281334
///
1329-
/// During type checking, these routines should be used instead of
1330-
/// \c MemberLookup and \c UnqualifiedLookup, because these routines will
1331-
/// lazily introduce declarations and (FIXME: eventually) perform recursive
1332-
/// type-checking that the AST-level lookup routines don't.
1333-
///
13341335
/// @{
13351336

13361337
/// Perform unqualified name lookup at the given source location
@@ -1405,9 +1406,6 @@ class TypeChecker final {
14051406
Identifier name,
14061407
SourceLoc nameLoc);
14071408

1408-
/// Given an pre-folded expression, find LHS from the expression if a binary
1409-
/// operator \c name appended to the expression.
1410-
static Expr *findLHS(DeclContext *DC, Expr *E, Identifier name);
14111409
/// Check whether the given declaration can be written as a
14121410
/// member of the given base type.
14131411
static bool isUnsupportedMemberTypeAccess(Type type, TypeDecl *typeDecl);

0 commit comments

Comments
 (0)