Skip to content

Commit 50c0796

Browse files
committed
---
yaml --- r: 349395 b: refs/heads/master-next c: 6675d10 h: refs/heads/master i: 349393: 8ac4a29 349391: 13a628a
1 parent 19bd099 commit 50c0796

File tree

4 files changed

+19
-19
lines changed

4 files changed

+19
-19
lines changed

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22
refs/heads/master: 3574c513bbc5578dd9346b4ea9ab5995c5927bb5
3-
refs/heads/master-next: c02c0017364c82109bbd8d3528fa14848eb13c1b
3+
refs/heads/master-next: 6675d10feecbb6e2c9937471a8128a57bec9d195
44
refs/tags/osx-passed: b6b74147ef8a386f532cf9357a1bde006e552c54
55
refs/tags/swift-2.2-SNAPSHOT-2015-12-01-a: 6bb18e013c2284f2b45f5f84f2df2887dc0f7dea
66
refs/tags/swift-2.2-SNAPSHOT-2015-12-01-b: 66d897bfcf64a82cb9a87f5e663d889189d06d07

branches/master-next/include/swift/ClangImporter/ClangImporter.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ class ClangImporter final : public ClangModuleLoader {
9393

9494
ClangImporter(ASTContext &ctx, const ClangImporterOptions &clangImporterOpts,
9595
DependencyTracker *tracker,
96-
std::unique_ptr<DWARFImporterDelegate> dwarfImporterDelegate);
96+
DWARFImporterDelegate *dwarfImporterDelegate);
9797

9898
ModuleDecl *loadModuleClang(SourceLoc importLoc,
9999
ArrayRef<std::pair<Identifier, SourceLoc>> path);
@@ -119,7 +119,7 @@ class ClangImporter final : public ClangModuleLoader {
119119
static std::unique_ptr<ClangImporter>
120120
create(ASTContext &ctx, const ClangImporterOptions &importerOpts,
121121
std::string swiftPCHHash = "", DependencyTracker *tracker = nullptr,
122-
std::unique_ptr<DWARFImporterDelegate> dwarfImporterDelegate = {});
122+
DWARFImporterDelegate *dwarfImporterDelegate = nullptr);
123123

124124
ClangImporter(const ClangImporter &) = delete;
125125
ClangImporter(ClangImporter &&) = delete;

branches/master-next/lib/ClangImporter/ClangImporter.cpp

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -386,13 +386,13 @@ bool ClangImporter::Implementation::shouldIgnoreBridgeHeaderTopLevelDecl(
386386
return false;
387387
}
388388

389-
ClangImporter::ClangImporter(
390-
ASTContext &ctx, const ClangImporterOptions &clangImporterOpts,
391-
DependencyTracker *tracker,
392-
std::unique_ptr<DWARFImporterDelegate> dwarfImporterDelegate)
389+
ClangImporter::ClangImporter(ASTContext &ctx,
390+
const ClangImporterOptions &clangImporterOpts,
391+
DependencyTracker *tracker,
392+
DWARFImporterDelegate *dwarfImporterDelegate)
393393
: ClangModuleLoader(tracker),
394-
Impl(*new Implementation(ctx, clangImporterOpts,
395-
std::move(dwarfImporterDelegate))) {}
394+
Impl(*new Implementation(ctx, clangImporterOpts, dwarfImporterDelegate)) {
395+
}
396396

397397
ClangImporter::~ClangImporter() {
398398
delete &Impl;
@@ -909,12 +909,12 @@ ClangImporter::getOrCreatePCH(const ClangImporterOptions &ImporterOptions,
909909
return PCHFilename.getValue();
910910
}
911911

912-
std::unique_ptr<ClangImporter> ClangImporter::create(
913-
ASTContext &ctx, const ClangImporterOptions &importerOpts,
914-
std::string swiftPCHHash, DependencyTracker *tracker,
915-
std::unique_ptr<DWARFImporterDelegate> dwarfImporterDelegate) {
916-
std::unique_ptr<ClangImporter> importer{new ClangImporter(
917-
ctx, importerOpts, tracker, std::move(dwarfImporterDelegate))};
912+
std::unique_ptr<ClangImporter>
913+
ClangImporter::create(ASTContext &ctx, const ClangImporterOptions &importerOpts,
914+
std::string swiftPCHHash, DependencyTracker *tracker,
915+
DWARFImporterDelegate *dwarfImporterDelegate) {
916+
std::unique_ptr<ClangImporter> importer{
917+
new ClangImporter(ctx, importerOpts, tracker, dwarfImporterDelegate)};
918918

919919
std::vector<std::string> invocationArgStrs;
920920

@@ -1843,7 +1843,7 @@ bool PlatformAvailability::treatDeprecatedAsUnavailable(
18431843

18441844
ClangImporter::Implementation::Implementation(
18451845
ASTContext &ctx, const ClangImporterOptions &opts,
1846-
std::unique_ptr<DWARFImporterDelegate> dwarfImporterDelegate)
1846+
DWARFImporterDelegate *dwarfImporterDelegate)
18471847
: SwiftContext(ctx),
18481848
ImportForwardDeclarations(opts.ImportForwardDeclarations),
18491849
InferImportAsMember(opts.InferImportAsMember),
@@ -1854,7 +1854,7 @@ ClangImporter::Implementation::Implementation(
18541854
CurrentVersion(ImportNameVersion::fromOptions(ctx.LangOpts)),
18551855
BridgingHeaderLookupTable(new SwiftLookupTable(nullptr)),
18561856
platformAvailability(ctx.LangOpts), nameImporter(),
1857-
DWARFImporter(std::move(dwarfImporterDelegate)) {}
1857+
DWARFImporter(dwarfImporterDelegate) {}
18581858

18591859
ClangImporter::Implementation::~Implementation() {
18601860
#ifndef NDEBUG

branches/master-next/lib/ClangImporter/ImporterImpl.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -322,7 +322,7 @@ class LLVM_LIBRARY_VISIBILITY ClangImporter::Implementation
322322

323323
public:
324324
Implementation(ASTContext &ctx, const ClangImporterOptions &opts,
325-
std::unique_ptr<DWARFImporterDelegate> dwarfImporterDelegate);
325+
DWARFImporterDelegate *dwarfImporterDelegate);
326326
~Implementation();
327327

328328
/// Swift AST context.
@@ -605,7 +605,7 @@ class LLVM_LIBRARY_VISIBILITY ClangImporter::Implementation
605605

606606
private:
607607
/// The DWARF importer delegate, if installed.
608-
std::unique_ptr<DWARFImporterDelegate> DWARFImporter;
608+
DWARFImporterDelegate *DWARFImporter = nullptr;
609609
/// The list of Clang modules found in the debug info.
610610
llvm::DenseMap<Identifier, LoadedFile *> DWARFModuleUnits;
611611

0 commit comments

Comments
 (0)