[stdlib] Substring: Restore original Range paths

lorentey · lorentey · commit 513a7d9e1904 · 2020-12-04T18:35:08.000-08:00
This eliminates a couple of _debugPreconditions which seem to change inlining enough to interfere with some benchmarks.
diff --git a/stdlib/public/core/Substring.swift b/stdlib/public/core/Substring.swift
@@ -105,7 +105,7 @@ public struct Substring {
 
     self._slice = Slice(
       base: slice.base,
-      bounds: Range(uncheckedBounds: (start, end)))
+      bounds: Range(_uncheckedBounds: (start, end)))
     _invariantCheck()
   }
 
@@ -132,7 +132,7 @@ extension Substring {
   @inlinable @inline(__always)
   internal var _offsetRange: Range<Int> {
     return Range(
-      uncheckedBounds: (startIndex._encodedOffset, endIndex._encodedOffset))
+      _uncheckedBounds: (startIndex._encodedOffset, endIndex._encodedOffset))
   }
 
   #if !INTERNAL_CHECKS_ENABLED

Original file line number	Diff line number	Diff line change
`@@ -105,7 +105,7 @@ public struct Substring {`
`105`	`105`
`106`	`106`	`self._slice = Slice(`
`107`	`107`	`base: slice.base,`
`108`		`- bounds: Range(uncheckedBounds: (start, end)))`
	`108`	`+ bounds: Range(_uncheckedBounds: (start, end)))`
`109`	`109`	`_invariantCheck()`
`110`	`110`	`}`
`111`	`111`
`@@ -132,7 +132,7 @@ extension Substring {`
`132`	`132`	`@inlinable @inline(__always)`
`133`	`133`	`internal var _offsetRange: Range<Int> {`
`134`	`134`	`return Range(`
`135`		`- uncheckedBounds: (startIndex._encodedOffset, endIndex._encodedOffset))`
	`135`	`+ _uncheckedBounds: (startIndex._encodedOffset, endIndex._encodedOffset))`
`136`	`136`	`}`
`137`	`137`
`138`	`138`	`#if !INTERNAL_CHECKS_ENABLED`