[SourceKit] Don't handle labels when renaming operators

This allows us to at least rename the base of operators. The labels don’t matter too much since they only occur on the function definition.

Author: ahoppen

lib/Refactoring/SyntacticRenameRangeDetails.cpp

@@ -470,8 +470,13 @@ RegionType RenameRangeDetailCollector::addSyntacticRenameRanges(
       isCallSite = true;
       break;
     case RenameLocUsage::Definition:
-      // All function definitions have argument labels that should be renamed.
-      handleLabels = true;
+      // Don't rename labels of operators. There is a mismatch between the
+      // indexer reporting all labels as `_` even if they are spelled as e.g.
+      // `x: Int` in the function declaration. Since the labels only appear
+      // on the operator declaration and in no calls, just don't rename them for
+      // now.
+      // For all other (normal) function declarations, always rename the labels.
+      handleLabels = !Lexer::isOperator(Old.base());
       isCallSite = false;
       break;
     case RenameLocUsage::Reference:

test/SourceKit/RelatedIdents/operator.swift

@@ -0,0 +1,17 @@
+// RUN: %empty-directory(%t)
+// RUN: split-file --leading-lines %s %t
+
+//--- a.swift
+
+struct Foo {}
+// RUN: %sourcekitd-test -req=related-idents -pos=%(line + 1):6 %t/a.swift -- %t/a.swift | %FileCheck %s
+func +(x: Foo, y: Foo) {}
+Foo() + Foo()
+
+//--- dummy.swift
+
+// CHECK: START RANGES
+// CHECK: 8:6 - 1 - source.syntacticrename.definition
+// CHECK: 9:7 - 1 - source.syntacticrename.call
+// CHECK: END RANGES
+// CHECK: NAME: +(_:_:)

test/refactoring/SyntacticRename/Outputs/functions/infix-operator.swift.expected

@@ -28,7 +28,7 @@ class AStruct {
         return {a in a};
     }
 
-    static func /*infix-operator:def*/<base>+</base> (<arglabel index=0>left</arglabel><param index=0></param>: AStruct, <arglabel index=1>right</arglabel><param index=1></param>: AStruct) -> AStruct {
+    static func /*infix-operator:def*/<base>+</base> (left: AStruct, right: AStruct) -> AStruct {
         return AStruct()
     }
 

test/refactoring/SyntacticRename/Outputs/functions/prefix-operator.swift.expected

@@ -32,7 +32,7 @@ class AStruct {
         return AStruct()
     }
 
-    static prefix func /*prefix-operator:def*/<base>-</base> (<arglabel index=0>struct</arglabel><param index=0></param>: AStruct) -> AStruct {
+    static prefix func /*prefix-operator:def*/<base>-</base> (struct: AStruct) -> AStruct {
         return AStruct()
     }
 }

test/refactoring/SyntacticRename/operator.swift

@@ -0,0 +1,17 @@
+// RUN: %empty-directory(%t)
+// RUN: split-file %s %t
+// RUN: %refactor -find-rename-ranges -source-filename %t/input.swift -pos="test" -old-name "+(x:y:)" -new-name "-(x:y:)" > %t/output.txt
+// RUN: diff -u %t/expected.swift %t/output.txt 
+
+//--- input.swift
+
+struct Foo {}
+func /*test:def*/+(x: Foo, y: Foo) {}
+Foo() /*test:ref*/+ Foo()
+
+//--- expected.swift
+
+struct Foo {}
+func /*test:def*/<base>+</base>(x: Foo, y: Foo) {}
+Foo() /*test:ref*/<base>+</base> Foo()
+