[ASTDumper] Special handling for init kind in pre-typecheck dump

Author: LucianoPAlmeida

lib/AST/ASTDumper.cpp

@@ -1174,8 +1174,23 @@ namespace {
       printCommonAFD(CD, "constructor_decl");
       if (CD->isRequired())
         PrintWithColorRAII(OS, DeclModifierColor) << " required";
-      PrintWithColorRAII(OS, DeclModifierColor) << " "
-        << getCtorInitializerKindString(CD->getInitKind());
+
+      CtorInitializerKind kind;
+      const auto *ED =
+          dyn_cast_or_null<ExtensionDecl>(CD->getDeclContext()->getAsDecl());
+      if (ED && !ED->hasBeenBound()) {
+        // When dumping pre-typechecked AST there is not enough information
+        // about extended nominal to use for computing init kind as
+        // bindExtensions is done at typechecking, so in that case just look to
+        // parsed attribute in init declaration.
+        kind = CD->getAttrs().hasAttribute<ConvenienceAttr>()
+                   ? CtorInitializerKind::Convenience
+                   : CtorInitializerKind::Designated;
+      } else {
+        kind = CD->getInitKind();
+      }
+      PrintWithColorRAII(OS, DeclModifierColor)
+          << " " << getCtorInitializerKindString(kind);
       if (CD->isFailable())
         PrintWithColorRAII(OS, DeclModifierColor) << " failable="
           << (CD->isImplicitlyUnwrappedOptional()

validation-test/compiler_crashers_2_fixed/issue-61086.swift

@@ -0,0 +1,20 @@
+// RUN: %target-typecheck-verify-swift -dump-parse
+
+// https://github.com/apple/swift/issues/61806
+
+struct I61806 {}
+extension I61806 {
+  init() { }
+}
+
+class I61806_C { 
+  init() {}
+}
+extension I61806_C {
+  convenience init(a: Int) {}
+}
+
+protocol I61806_P {}
+extension I61806_P {
+ init() {}
+}