Skip to content

Commit 5308a2a

Browse files
authored
Remove stale references to '@_semantics(optimize.sil.preserve_exclusivity)'. (#17501)
1 parent 224fa2a commit 5308a2a

File tree

2 files changed

+0
-8
lines changed

2 files changed

+0
-8
lines changed

lib/SILOptimizer/Mandatory/AccessMarkerElimination.cpp

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,6 @@
1818
/// This is an always-on pass for temporary bootstrapping. It allows running
1919
/// test cases through the pipeline and exercising SIL verification before all
2020
/// passes support access markers.
21-
///
22-
/// This must only run before inlining _semantic calls. If we inline and drop
23-
/// the @_semantics("optimize.sil.preserve_exclusivity") attribute, the inlined
24-
/// markers will be eliminated, but the noninlined markers will not. This would
25-
/// result in inconsistent begin/end_unpaired_access resulting in unpredictable,
26-
/// potentially catastrophic runtime behavior.
27-
///
2821
//===----------------------------------------------------------------------===//
2922

3023
#define DEBUG_TYPE "access-marker-elim"

test/IRGen/preserve_exclusivity.swift

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ public func endAccess(_ address: Builtin.RawPointer) {
3232
// CHECK-LABEL: define {{.*}}swiftcc void @"$S20preserve_exclusivity10readAccessyyBp_xmtlF"(i8*, %swift.type*{{.*}}, %swift.type*{{.*}} %T1)
3333
// CHECK: call void @swift_beginAccess
3434
// CHECK: ret void
35-
@_semantics("optimize.sil.preserve_exclusivity")
3635
public func readAccess<T1>(_ address: Builtin.RawPointer, _ ty1: T1.Type) {
3736
marker3()
3837
Builtin.performInstantaneousReadAccess(address, ty1);

0 commit comments

Comments
 (0)