Remove (unneeded) support for copy_value in initializer analysis

Author: zoecarver

lib/SIL/SILVerifier.cpp

@@ -4733,12 +4733,6 @@ class SILVerifier : public SILVerifierBase<SILVerifier> {
           if (term->isFunctionExiting()) {
             require(state.Stack.empty(),
                     "return with stack allocs that haven't been deallocated");
-            if (!state.ActiveOps.empty()) {
-              for (auto *i : state.ActiveOps) {
-                i->dump();
-              }
-            }
-
             require(state.ActiveOps.empty(),
                     "return with operations still active");
 

lib/SILOptimizer/IPO/LetPropertiesOpts.cpp

@@ -400,8 +400,6 @@ LetPropertiesOpt::analyzeInitValue(SILInstruction *I, VarDecl *Property) {
            && "Store instruction should store into a proper let property");
     (void) Dest;
     value = SI->getSrc();
-  } else if (auto *copyValue = dyn_cast<CopyValueInst>(I)) {
-    value = copyValue->getOperand();
   } else if (auto *copyAddr = dyn_cast<CopyAddrInst>(I)) {
     value = copyAddr->getSrc();
   }
@@ -524,7 +522,7 @@ void LetPropertiesOpt::collectPropertyAccess(SILInstruction *I,
 
   if (isa<RefElementAddrInst>(I) || isa<StructElementAddrInst>(I)
       || isa<BeginAccessInst>(I) || isa<CopyAddrInst>(I) ||
-      isa<CopyValueInst>(I) || isa<BeginBorrowInst>(I)) {
+      isa<BeginBorrowInst>(I)) {
     // Check if there is a store to this property.
     auto projection = cast<SingleValueInstruction>(I);
     for (auto Use : getNonDebugUses(projection)) {
@@ -546,14 +544,6 @@ void LetPropertiesOpt::collectPropertyAccess(SILInstruction *I,
         continue;
       }
 
-      if (auto *copyVal = dyn_cast<CopyValueInst>(User)) {
-        if (copyVal != projection || !analyzeInitValue(copyVal, Property)) {
-          SkipProcessing.insert(Property);
-          return;
-        }
-        continue;
-      }
-
       if (auto *SI = dyn_cast<StoreInst>(User)) {
         // There is a store into this property.
         // Analyze the assigned value and check if it is a constant

lib/SILOptimizer/Transforms/SILMem2Reg.cpp

@@ -956,9 +956,9 @@ class SILMem2Reg : public SILFunctionTransform {
   void run() override {
     SILFunction *F = getFunction();
 
-//    // FIXME: We should be able to support ownership.
-//    if (F->hasOwnership())
-//      return;
+    // FIXME: We should be able to support ownership.
+    if (F->hasOwnership())
+      return;
 
     LLVM_DEBUG(llvm::dbgs() << "** Mem2Reg on function: " << F->getName()
                             << " **\n");