RequirementMachine: Make some low-cost assertions unconditional

Author: slavapestov

lib/AST/RequirementMachine/GenericSignatureQueries.cpp

@@ -239,7 +239,8 @@ RequirementMachine::getLongestValidPrefix(const MutableTerm &term) const {
     case Symbol::Kind::Superclass:
     case Symbol::Kind::ConcreteType:
     case Symbol::Kind::ConcreteConformance:
-      llvm_unreachable("Property symbol cannot appear in a type term");
+      llvm::errs() <<"Invalid symbol in a type term: " << term << "\n";
+      abort();
     }
 
     // This symbol is valid, add it to the longest prefix.

lib/AST/RequirementMachine/InterfaceType.cpp

@@ -311,7 +311,8 @@ getTypeForSymbolRange(const Symbol *begin, const Symbol *end, Type root,
       case Symbol::Kind::Superclass:
       case Symbol::Kind::ConcreteType:
       case Symbol::Kind::ConcreteConformance:
-        llvm_unreachable("Term has invalid root symbol");
+        llvm::errs() << "Invalid root symbol: " << MutableTerm(begin, end) << "\n";
+        abort();
       }
     }
 

lib/AST/RequirementMachine/MinimalConformances.cpp

@@ -365,7 +365,8 @@ static const ProtocolDecl *getParentConformanceForTerm(Term lhs) {
     break;
   }
 
-  llvm_unreachable("Bad symbol kind");
+  llvm::errs() << "Bad symbol in " << lhs << "\n";
+  abort();
 }
 
 /// Collect conformance rules and parent paths, and record an initial

lib/AST/RequirementMachine/Symbol.cpp

@@ -596,7 +596,8 @@ Symbol Symbol::withConcreteSubstitutions(
     break;
   }
 
-  llvm_unreachable("Bad symbol kind");
+  llvm::errs() << "Bad symbol kind: " << *this << "\n";
+  abort();
 }
 
 /// For a superclass or concrete type symbol