[3.0 compat] Don't diagnose @escaping var-arg closures.

Var-arg closures are already escaping, so we typically want to issue
an error if @escaping is specified. To not do sure will confuse and
give a false impression on the un-annotated semantics and whether it
is needed. But, 3.0 shipped with a bug where we didn't consistently
apply the no-escape-by-default rule here, and thus it was semantically
meaningful (and needed).

In order to preserve source compatibility, albeit at the expense of
developers on versions 3.0.1 and later in the Swift 3 family, we
suppress the error if we see @escaping. Either way, this is a
relatively uncommon usage, so the confusion won't be too wide spread.

Author: milseman

lib/Sema/TypeCheckType.cpp

@@ -2032,8 +2032,16 @@ Type TypeResolver::resolveAttributedType(TypeAttributes &attrs,
   // Handle @escaping
   if (hasFunctionAttr && ty->is<FunctionType>()) {
     if (attrs.has(TAK_escaping)) {
+      // For compatibility with 3.0, we don't emit an error if it appears on a
+      // variadic argument list.
+      //
+      // FIXME: Version-gate on Swift language version 3, as we don't want its
+      // presence to confuse users.
+      bool skipDiagnostic = isVariadicFunctionParam;
+
       // The attribute is meaningless except on parameter types.
-      if (!isFunctionParam) {
+      bool shouldDiagnose = !isFunctionParam && !skipDiagnostic;
+      if (shouldDiagnose) {
         auto &SM = TC.Context.SourceMgr;
         auto loc = attrs.getLoc(TAK_escaping);
         auto attrRange = SourceRange(

test/attr/attr_escaping.swift

@@ -140,6 +140,11 @@ func takesVarargsOfFunctions(fns: () -> ()...) {
   }
 }
 
+// This is allowed, in order to keep source compat with Swift version 3.0.
+//
+// FIXME: version-gate on Swift version 3
+func takesVarargsOfFunctionsExplicitEscaping(fns: @escaping () -> ()...) {}
+
 func takesNoEscapeFunction(fn: () -> ()) { // expected-note {{parameter 'fn' is implicitly non-escaping}}
   takesVarargsOfFunctions(fns: fn) // expected-error {{passing non-escaping parameter 'fn' to function expecting an @escaping closure}}
 }