Skip to content

Commit 5617856

Browse files
committed
[Distributed] remove DistributedAvailability, reuse Concurrency one
1 parent fbd66e2 commit 5617856

File tree

9 files changed

+4
-51
lines changed

9 files changed

+4
-51
lines changed

include/swift/AST/ASTContext.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -753,9 +753,6 @@ class ASTContext final {
753753
/// Get the runtime availability of support for concurrency.
754754
AvailabilityContext getConcurrencyAvailability();
755755

756-
/// Get the runtime availability of support for distributed actors.
757-
AvailabilityContext getDistributedAvailability();
758-
759756
/// Get the runtime availability of support for differentiation.
760757
AvailabilityContext getDifferentiationAvailability();
761758

include/swift/Frontend/Frontend.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -533,10 +533,6 @@ class CompilerInstance {
533533
/// i.e. if it can be found.
534534
bool canImportSwiftConcurrency() const;
535535

536-
/// Whether the Distributed actors support library can be imported
537-
/// i.e. if it can be found.
538-
bool canImportSwiftDistributed() const;
539-
540536
/// Gets the SourceFile which is the primary input for this CompilerInstance.
541537
/// \returns the primary SourceFile, or nullptr if there is no primary input;
542538
/// if there are _multiple_ primary inputs, fails with an assertion.

include/swift/Runtime/RuntimeFunctions.def

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1692,15 +1692,15 @@ FUNCTION(DefaultActorDeallocateResilient,
16921692
// );
16931693
FUNCTION(DistributedActorInitializeRemote,
16941694
swift_distributedActor_remote_initialize, SwiftCC,
1695-
DistributedAvailability,
1695+
ConcurrencyAvailability, // TODO(distributed): Introduce DistributedAvailability once shipping somewhere
16961696
RETURNS(OpaquePtrTy),
16971697
ARGS(TypeMetadataPtrTy),
16981698
ATTRS(NoUnwind))
16991699

17001700
// void swift_distributedActor_destroy(DefaultActor *actor);
17011701
FUNCTION(DistributedActorDestroy,
17021702
swift_distributedActor_destroy, SwiftCC,
1703-
DistributedAvailability,
1703+
ConcurrencyAvailability, // TODO(distributed): Introduce DistributedAvailability once shipping somewhere
17041704
RETURNS(VoidTy),
17051705
ARGS(RefCountedPtrTy),
17061706
ATTRS(NoUnwind))

lib/AST/Availability.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -330,10 +330,6 @@ AvailabilityContext ASTContext::getConcurrencyAvailability() {
330330
return getSwift55Availability();
331331
}
332332

333-
AvailabilityContext ASTContext::getDistributedAvailability() {
334-
return getSwift55Availability(); // FIXME(distributed): getSwiftFutureAvailability perhaps? The module is not shipping in any release so far so it does not matter for real though.
335-
}
336-
337333
AvailabilityContext ASTContext::getDifferentiationAvailability() {
338334
return getSwiftFutureAvailability();
339335
}

lib/Frontend/Frontend.cpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -819,11 +819,6 @@ bool CompilerInstance::canImportSwiftConcurrency() const {
819819
{getASTContext().getIdentifier(SWIFT_CONCURRENCY_NAME), SourceLoc()});
820820
}
821821

822-
bool CompilerInstance::canImportSwiftDistributed() const {
823-
return getASTContext().canImportModule(
824-
{getASTContext().getIdentifier(SWIFT_DISTRIBUTED_NAME), SourceLoc()});
825-
}
826-
827822
ImplicitImportInfo CompilerInstance::getImplicitImportInfo() const {
828823
auto &frontendOpts = Invocation.getFrontendOptions();
829824

lib/IRGen/IRGenModule.cpp

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -786,14 +786,6 @@ namespace RuntimeConstants {
786786
return RuntimeAvailability::AlwaysAvailable;
787787
}
788788

789-
RuntimeAvailability DistributedAvailability(ASTContext &context) {
790-
auto featureAvailability = context.getDistributedAvailability();
791-
if (!isDeploymentAvailabilityContainedIn(context, featureAvailability)) {
792-
return RuntimeAvailability::ConditionallyAvailable;
793-
}
794-
return RuntimeAvailability::AlwaysAvailable;
795-
}
796-
797789
RuntimeAvailability DifferentiationAvailability(ASTContext &context) {
798790
auto featureAvailability = context.getDifferentiationAvailability();
799791
if (!isDeploymentAvailabilityContainedIn(context, featureAvailability)) {

lib/Sema/TypeCheckAvailability.cpp

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1702,24 +1702,6 @@ void TypeChecker::checkConcurrencyAvailability(SourceRange ReferenceRange,
17021702
}
17031703
}
17041704

1705-
void TypeChecker::checkDistributedAvailability(SourceRange ReferenceRange,
1706-
const DeclContext *ReferenceDC) {
1707-
// Check the availability of concurrency runtime support.
1708-
ASTContext &ctx = ReferenceDC->getASTContext();
1709-
if (ctx.LangOpts.DisableAvailabilityChecking)
1710-
return;
1711-
1712-
auto runningOS =
1713-
TypeChecker::overApproximateAvailabilityAtLocation(
1714-
ReferenceRange.Start, ReferenceDC);
1715-
auto availability = ctx.getDistributedAvailability();
1716-
if (!runningOS.isContainedIn(availability)) {
1717-
diagnosePotentialConcurrencyUnavailability(
1718-
ReferenceRange, ReferenceDC,
1719-
UnavailabilityReason::requiresVersionRange(availability.getOSVersion()));
1720-
}
1721-
}
1722-
17231705
void TypeChecker::diagnosePotentialUnavailability(
17241706
const ValueDecl *D, SourceRange ReferenceRange,
17251707
const DeclContext *ReferenceDC,

lib/Sema/TypeCheckDeclPrimary.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2418,11 +2418,9 @@ class DeclChecker : public DeclVisitor<DeclChecker> {
24182418

24192419
TypeChecker::checkDeclAttributes(CD);
24202420

2421-
if (CD->isActor()) {
2421+
if (CD->isActor())
24222422
TypeChecker::checkConcurrencyAvailability(CD->getLoc(), CD);
2423-
if (CD->isDistributedActor())
2424-
TypeChecker::checkDistributedAvailability(CD->getLoc(), CD);
2425-
}
2423+
24262424
for (Decl *Member : CD->getABIMembers())
24272425
visit(Member);
24282426

lib/Sema/TypeChecker.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1026,9 +1026,6 @@ void checkDistributedActor(ClassDecl *decl);
10261026
void checkConcurrencyAvailability(SourceRange ReferenceRange,
10271027
const DeclContext *ReferenceDC);
10281028

1029-
void checkDistributedAvailability(SourceRange ReferenceRange,
1030-
const DeclContext *ReferenceDC);
1031-
10321029
/// Emits a diagnostic for a reference to a storage accessor that is
10331030
/// potentially unavailable.
10341031
void diagnosePotentialAccessorUnavailability(

0 commit comments

Comments
 (0)