Skip to content

Commit 573dd3e

Browse files
committed
Add miscellaneous todo comments.
1 parent b6cd1d7 commit 573dd3e

File tree

5 files changed

+8
-9
lines changed

5 files changed

+8
-9
lines changed

include/swift/AST/AutoDiff.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -484,7 +484,7 @@ class AutoDiffDerivativeFunctionIdentifier : public llvm::FoldingSetNode {
484484
/// The key type used for uniquing `SILDifferentiabilityWitness` in
485485
/// `SILModule`: original function name, parameter indices, result indices, and
486486
/// derivative generic signature.
487-
// TODO: Unify with `AutoDiffDerivativeFunctionIdentifier`.
487+
// TODO(TF-893): Unify with `AutoDiffDerivativeFunctionIdentifier`.
488488
using SILDifferentiabilityWitnessKey =
489489
std::tuple<StringRef, AutoDiffIndexSubset *,
490490
AutoDiffIndexSubset *, GenericSignature *>;

lib/AST/ASTMangler.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -429,7 +429,6 @@ std::string ASTMangler::mangleAutoDiffLinearMapHelper(
429429
std::string ASTMangler::mangleSILDifferentiabilityWitnessKey(
430430
SILDifferentiabilityWitnessKey key) {
431431
// TODO(TF-20): Make the mangling scheme robust.
432-
// TODO(TF-680): Mangle derivative generic signature as well.
433432
beginManglingWithoutPrefix();
434433

435434
auto originalName = std::get<0>(key);

lib/ParseSIL/ParseSIL.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6746,7 +6746,7 @@ bool SILParserTUState::parseSILDefaultWitnessTable(Parser &P) {
67466746
}
67476747

67486748
// SWIFT_ENABLE_TENSORFLOW
6749-
// TODO: Dedupe with `SILParser::convertRequirements` upstream.
6749+
// TODO(TF-893): Dedupe with `SILParser::convertRequirements` upstream.
67506750
// Consider defining this as `Parser::convertRequirements`.
67516751
static void convertRequirements(Parser &P, SILFunction *F,
67526752
ArrayRef<RequirementRepr> From,
@@ -6956,7 +6956,7 @@ bool SILParserTUState::parseSILDifferentiabilityWitness(Parser &P) {
69566956
return true;
69576957
}
69586958

6959-
// TODO: Parse `isSerialized` flag.
6959+
// TODO(TF-893): Parse `isSerialized` flag.
69606960
bool isSerialized = false;
69616961
SILDifferentiabilityWitness::create(
69626962
M, *linkage, originalFn, parameterIndices, resultIndices,

lib/SIL/SILPrinter.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2712,7 +2712,7 @@ static void printSILDifferentiabilityWitnesses(
27122712
std::sort(sortedDiffWitnesses.begin(), sortedDiffWitnesses.end(),
27132713
[] (const SILDifferentiabilityWitness *w1,
27142714
const SILDifferentiabilityWitness *w2) -> bool {
2715-
// TODO: Sort based on more criteria for deterministic ordering.
2715+
// TODO(TF-893): Sort based on more criteria for deterministic ordering.
27162716
return w1->getOriginalFunction()->getName()
27172717
.compare(w2->getOriginalFunction()->getName());
27182718
}

lib/SIL/SILVerifier.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5359,8 +5359,8 @@ void SILDifferentiabilityWitness::verify(const SILModule &M) const {
53595359
#endif
53605360
auto origFnType = originalFunction->getLoweredFunctionType();
53615361
if (jvp) {
5362-
// TODO: Change `SILFunctionType::getAutoDiffDerivativeFunctionType` to
5363-
// accept result indices.
5362+
// TODO(TF-893): Change `SILFunctionType::getAutoDiffDerivativeFunctionType`
5363+
// to accept result indices.
53645364
auto expectedJVPType = origFnType->getAutoDiffDerivativeFunctionType(
53655365
getParameterIndices(), /*resultIndex*/ *resultIndices->begin(),
53665366
AutoDiffDerivativeFunctionKind::JVP, M.Types,
@@ -5372,8 +5372,8 @@ void SILDifferentiabilityWitness::verify(const SILModule &M) const {
53725372
"JVP type does not match expected JVP type");
53735373
}
53745374
if (vjp) {
5375-
// TODO: Change `SILFunctionType::getAutoDiffDerivativeFunctionType` to
5376-
// accept result indices.
5375+
// TODO(TF-893): Change `SILFunctionType::getAutoDiffDerivativeFunctionType`
5376+
// to result indices.
53775377
auto expectedVJPType = origFnType->getAutoDiffDerivativeFunctionType(
53785378
getParameterIndices(), /*resultIndex*/ *resultIndices->begin(),
53795379
AutoDiffDerivativeFunctionKind::VJP, M.Types,

0 commit comments

Comments
 (0)