Reenable stripping of access markers at -O.

Until other bugs are fixed, this is still required in the short term after
mandatory inlining of debug libraries into an optimized executable.

Also, enable rerunning access marker elimination on deserialized functions,
because theoretically, the same problem could occur if we emit an external
function without inlining it.

Author: atrick

lib/SILOptimizer/Mandatory/AccessEnforcementSelection.cpp

@@ -562,12 +562,6 @@ void AccessEnforcementSelection::run() {
 }
 
 void AccessEnforcementSelection::processFunction(SILFunction *F) {
-  if (F->wasDeserializedCanonical()) {
-    DEBUG(llvm::dbgs() << "Skipping Access Enforcement Selection of "
-                          "deserialized "
-                       << F->getName() << "\n");
-    return;
-  }
   DEBUG(llvm::dbgs() << "Access Enforcement Selection in " << F->getName()
                      << "\n");
 #ifndef NDEBUG

lib/SILOptimizer/Mandatory/AccessMarkerElimination.cpp

@@ -36,7 +36,7 @@ using namespace swift;
 // This is currently unsupported because tail duplication results in
 // address-type block arguments.
 llvm::cl::opt<bool> EnableOptimizedAccessMarkers(
-    "sil-optimized-access-markers", llvm::cl::init(true),
+    "sil-optimized-access-markers", llvm::cl::init(false),
     llvm::cl::desc("Enable memory access markers during optimization passes."));
 
 namespace {

test/SILOptimizer/access_marker_elim.sil

@@ -1,5 +1,5 @@
 // RUN: %target-sil-opt -enforce-exclusivity=unchecked -emit-sorted-sil -access-marker-elim %s | %FileCheck %s --check-prefix=UNCHECKED
-// RUN: %target-sil-opt -enforce-exclusivity=checked -emit-sorted-sil -access-marker-elim %s | %FileCheck %s --check-prefix=CHECKED
+// FIXME: %target-sil-opt -enforce-exclusivity=checked -emit-sorted-sil -access-marker-elim %s | %FileCheck %s --check-prefix=CHECKED
 
 sil_stage raw