Skip to content

Commit 596e558

Browse files
author
marcrasi
authored
---
yaml --- r: 341625 b: refs/heads/rxwei-patch-1 c: 10f2f45 h: refs/heads/master i: 341623: 6b60121
1 parent b069201 commit 596e558

File tree

3 files changed

+10
-5
lines changed

3 files changed

+10
-5
lines changed

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1015,7 +1015,7 @@ refs/tags/swift-DEVELOPMENT-SNAPSHOT-2018-08-18-a: b10b1fce14385faa6d44f6b933e95
10151015
refs/heads/rdar-43033749-fix-batch-mode-no-diags-swift-5.0-branch: a14e64eaad30de89f0f5f0b2a782eed7ecdcb255
10161016
refs/heads/revert-19006-error-bridging-integer-type: 8a9065a3696535305ea53fe9b71f91cbe6702019
10171017
refs/heads/revert-19050-revert-19006-error-bridging-integer-type: ecf752d54b05dd0a20f510f0bfa54a3fec3bcaca
1018-
refs/heads/rxwei-patch-1: 019b2e43df7a209d0ae806284c203def48d3d503
1018+
refs/heads/rxwei-patch-1: 10f2f451df5374593ce6e62110b657eee1f26540
10191019
refs/heads/shahmishal-patch-1: e58ec0f7488258d42bef51bc3e6d7b3dc74d7b2a
10201020
refs/heads/typelist-existential: 4046359efd541fb5c72d69a92eefc0a784df8f5e
10211021
refs/tags/swift-4.2-DEVELOPMENT-SNAPSHOT-2018-08-20-a: 4319ba09e4fb8650ee86061075c74a016b6baab9

branches/rxwei-patch-1/stdlib/private/DifferentiationUnittest/DifferentiationUnittest.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
//===--- GenericLifetimeTracked.swift -------------------------------------===//
1+
//===--- DifferentiationUnittest.swift ------------------------------------===//
22
//
33
// This source file is part of the Swift.org open source project
44
//

branches/rxwei-patch-1/test/AutoDiff/leakchecking.swift

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,16 +8,21 @@ import DifferentiationUnittest
88

99
var LeakCheckingTests = TestSuite("LeakChecking")
1010

11-
/// Execute body, check expected leak count, and reset global leak count.
11+
/// Execute body and check expected leak count.
1212
func testWithLeakChecking(
1313
expectedLeakCount: Int = 0, file: String = #file, line: UInt = #line,
1414
_ body: () -> Void
1515
) {
16+
// Note: compare expected leak count with relative leak count after
17+
// running `body`.
18+
// This approach is more robust than comparing leak count with zero
19+
// and resetting leak count to zero, which is stateful and causes issues.
20+
let beforeLeakCount = _GlobalLeakCount.count
1621
body()
22+
let leakCount = _GlobalLeakCount.count - beforeLeakCount
1723
expectEqual(
18-
expectedLeakCount, _GlobalLeakCount.count, "Leak detected.",
24+
expectedLeakCount, leakCount, "Leaks detected: \(leakCount)",
1925
file: file, line: line)
20-
_GlobalLeakCount.count = 0
2126
}
2227

2328
struct ExampleLeakModel : Differentiable {

0 commit comments

Comments
 (0)