Skip to content

Commit 5ca7c79

Browse files
AnthonyLatsisAnthonyLatsis
committed
Gardening: Migrate compiler sources to GitHub issues
1 parent 0a9b558 commit 5ca7c79

32 files changed

+69
-77
lines changed

‎lib/CMakeLists.txt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,9 @@
22
# Swift's libraries all build after the LLVM & Clang tablegen-generated headers
33
# are generated. When building out-of-tree (as with build-script) LLVM & Clang's
44
# CMake configuration files create these targets as dummies so we can safely
5-
# depend on them directly here (See: SR-6026)
5+
# depend on them directly here.
6+
# See https://github.com/apple/swift/issues/48583.
7+
#
68
# LLVM_COMMON_DEPENDS is a construct from the LLVM build system. It is a special
79
# purpose variable that provides common dependencies for all libraries, and
810
# executables generated when it is set. CMake's scoping rules enforce that these

‎lib/ClangImporter/ClangImporter.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3125,7 +3125,7 @@ class VectorDeclPtrConsumer : public swift::VisibleDeclConsumer {
31253125
};
31263126
} // unnamed namespace
31273127

3128-
// FIXME: should submodules still be crawled for the symbol graph? (SR-15753)
3128+
// FIXME: should submodules still be crawled for the symbol graph? (https://github.com/apple/swift-docc/issues/190)
31293129
bool ClangModuleUnit::shouldCollectDisplayDecls() const { return isTopLevel(); }
31303130

31313131
void ClangModuleUnit::getTopLevelDecls(SmallVectorImpl<Decl*> &results) const {

‎lib/ClangImporter/ImportDecl.cpp

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2002,7 +2002,7 @@ namespace {
20022002
return nullptr;
20032003
}
20042004

2005-
// TODO(SR-13809): fix this once we support dependent types.
2005+
// TODO: fix this once we support dependent types. (https://github.com/apple/swift/issues/56206)
20062006
if (decl->getTypeForDecl()->isDependentType()) {
20072007
Impl.addImportDiagnostic(
20082008
decl, Diagnostic(
@@ -3006,8 +3006,7 @@ namespace {
30063006

30073007
auto templateParamTypeUsedInSignature =
30083008
[decl](clang::TemplateTypeParmDecl *type) -> bool {
3009-
// TODO(SR-13809): we will want to update this to handle dependent
3010-
// types when those are supported.
3009+
// TODO: we will want to update this to handle dependent types when those are supported. (https://github.com/apple/swift/issues/56206)
30113010
if (hasSameUnderlyingType(decl->getReturnType().getTypePtr(), type))
30123011
return true;
30133012

@@ -3038,8 +3037,7 @@ namespace {
30383037
//
30393038
// If the defaulted template type parameter is used in the signature,
30403039
// then still add a generic so that it can be overrieded.
3041-
// TODO(SR-14837): in the future we might want to import two overloads
3042-
// in this case so that the default type could still be used.
3040+
// TODO: In the future we might want to import two overloads in this case so that the default type could still be used. (https://github.com/apple/swift/issues/57184)
30433041
if (templateTypeParam->hasDefaultArgument() &&
30443042
!templateParamTypeUsedInSignature(templateTypeParam))
30453043
continue;

‎lib/ClangImporter/ImportMacro.cpp

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -405,7 +405,7 @@ static ValueDecl *importMacro(ClangImporter::Implementation &impl,
405405
tokenI[2].is(clang::tok::r_paren)) {
406406
if (!castType.isNull()) {
407407
// this is a nested cast
408-
// TODO(SR-15429): Diagnose nested cast
408+
// TODO: Diagnose nested cast. (https://github.com/apple/swift/issues/57735)
409409
return nullptr;
410410
}
411411

@@ -428,11 +428,11 @@ static ValueDecl *importMacro(ClangImporter::Implementation &impl,
428428
if (parsedType && diagPool.empty()) {
429429
castType = parsedType.get();
430430
} else {
431-
// TODO(SR-15429): Add diagnosis
431+
// TODO: Add diagnosis. (https://github.com/apple/swift/issues/57735)
432432
return nullptr;
433433
}
434434
if (!castType->isBuiltinType() && !castTypeIsId) {
435-
// TODO(SR-15429): Add diagnosis
435+
// TODO: Add diagnosis. (https://github.com/apple/swift/issues/57735)
436436
return nullptr;
437437
}
438438
} else {
@@ -441,7 +441,7 @@ static ValueDecl *importMacro(ClangImporter::Implementation &impl,
441441
if (builtinType) {
442442
castType = builtinType.getValue();
443443
} else {
444-
// TODO(SR-15429): Add diagnosis
444+
// TODO: Add diagnosis. (https://github.com/apple/swift/issues/57735)
445445
return nullptr;
446446
}
447447
}
@@ -499,8 +499,7 @@ static ValueDecl *importMacro(ClangImporter::Implementation &impl,
499499
// FIXME: If the identifier refers to a declaration, alias it?
500500
}
501501

502-
// TODO(SR-15429): Seems rare to have a single token that is neither a
503-
// literal nor an identifier, but add diagnosis
502+
// TODO: Seems rare to have a single token that is neither a literal nor an identifier, but add diagnosis. (https://github.com/apple/swift/issues/57735)
504503
return nullptr;
505504
}
506505
case 2: {

‎lib/ClangImporter/ImportType.cpp

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ namespace {
227227

228228
ImportResult VisitType(const Type*) = delete;
229229

230-
// TODO: Add support for dependent types (SR-13809).
230+
// TODO: Add support for dependent types. (https://github.com/apple/swift/issues/56206)
231231
#define DEPENDENT_TYPE(Class, Base) \
232232
ImportResult Visit##Class##Type(const clang::Class##Type *) { return Impl.SwiftContext.getAnyExistentialType(); }
233233
#define TYPE(Class, Base)
@@ -697,10 +697,9 @@ namespace {
697697
if (!swiftParamTy)
698698
return Type();
699699

700-
// FIXME: If we were walking TypeLocs, we could actually get parameter
701-
// names. The probably doesn't matter outside of a FuncDecl, which
702-
// we'll have to special-case, but it's an interesting bit of data loss.
703-
// <https://bugs.swift.org/browse/SR-2529>
700+
// FIXME: If we were walking TypeLocs, we could actually get parameter names. (https://github.com/apple/swift/issues/45134)
701+
// The probably doesn't matter outside of a FuncDecl, which we'll have
702+
// to special-case, but it's an interesting bit of data loss.
704703
params.push_back(FunctionType::Param(swiftParamTy));
705704
}
706705

@@ -2446,7 +2445,7 @@ ParameterList *ClangImporter::Implementation::importFunctionParameterList(
24462445
bool shouldCheckResultType) -> bool {
24472446
auto paramDecl = genericParam->getClangDecl();
24482447
auto templateTypeParam = cast<clang::TemplateTypeParmDecl>(paramDecl);
2449-
// TODO(SR-13809): This won't work when we support importing dependent types.
2448+
// TODO: This won't work when we support importing dependent types. (https://github.com/apple/swift/issues/56206)
24502449
// We'll have to change this logic to traverse the type tree of the imported
24512450
// Swift type (basically whatever ends up in the parameters variable).
24522451
// Check if genericParam's corresponding clang template type is used by

‎lib/Driver/DarwinToolChains.cpp

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -466,10 +466,11 @@ toolchains::Darwin::addArgsToLinkStdlib(ArgStringList &Arguments,
466466
// If the user has explicitly asked for a toolchain stdlib, we should
467467
// provide one using -rpath. This used to be the default behaviour but it
468468
// was considered annoying in at least the SwiftPM scenario (see
469-
// https://bugs.swift.org/browse/SR-1967) and is obsolete in all scenarios
470-
// of deploying for Swift-in-the-OS. We keep it here as an optional
471-
// behaviour so that people downloading snapshot toolchains for testing new
472-
// stdlibs will be able to link to the stdlib bundled in that toolchain.
469+
// https://github.com/apple/swift/issues/44576) and is obsolete in all
470+
// scenarios of deploying for Swift-in-the-OS. We keep it here as an
471+
// optional behaviour so that people downloading snapshot toolchains for
472+
// testing new stdlibs will be able to link to the stdlib bundled in
473+
// that toolchain.
473474
for (auto path : RuntimeLibPaths) {
474475
Arguments.push_back("-rpath");
475476
Arguments.push_back(context.Args.MakeArgString(path));

‎lib/Driver/Driver.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2391,7 +2391,7 @@ bool Driver::handleImmediateArgs(const ArgList &Args, const ToolChain &TC) {
23912391

23922392
std::string executable = getSwiftProgramPath();
23932393

2394-
// FIXME: This bypasses mechanisms like -v and -###. (SR-12119)
2394+
// FIXME: This bypasses mechanisms like -v and -###. (https://github.com/apple/swift/issues/54554)
23952395
sys::TaskQueue queue;
23962396
queue.addTask(executable.c_str(), commandLine);
23972397
queue.execute(nullptr,

‎lib/Frontend/ModuleInterfaceSupport.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ llvm::Regex swift::getSwiftInterfaceCompilerVersionRegex() {
8181
": (.+)$", llvm::Regex::Newline);
8282
}
8383

84-
// MARK: Module name shadowing warnings (SR-898)
84+
// MARK: Module name shadowing warnings (https://github.com/apple/swift/issues/43510)
8585
//
8686
// When swiftc emits a module interface, it qualifies most types with their
8787
// module name. This usually makes the interface less ambiguous, but if a type

‎lib/FrontendTool/FrontendTool.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2276,8 +2276,8 @@ int swift::performFrontend(ArrayRef<const char *> Args,
22762276
// diagnostics emitted above, within CompilerInvocation::parseArgs, are never
22772277
// serialized. This is a non-issue because, in nearly all cases, frontend
22782278
// arguments are generated by the driver, not directly by a user. The driver
2279-
// is responsible for emitting diagnostics for its own errors. See SR-2683
2280-
// for details.
2279+
// is responsible for emitting diagnostics for its own errors.
2280+
// See https://github.com/apple/swift/issues/45288 for details.
22812281
std::unique_ptr<DiagnosticConsumer> SerializedConsumerDispatcher =
22822282
createSerializedDiagnosticConsumerIfNeeded(
22832283
Invocation.getFrontendOptions().InputsAndOutputs);

‎lib/FrontendTool/LoadedModuleTrace.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -169,8 +169,7 @@ class ABIDependencyEvaluator {
169169

170170
/// Check if a Swift module is an overlay for some Clang module.
171171
///
172-
/// FIXME: Delete this hack once SR-13363 is fixed and ModuleDecl has the
173-
/// right API which we can use directly.
172+
/// FIXME: Delete this hack once https://github.com/apple/swift/issues/55804 is fixed and ModuleDecl has the right API which we can use directly.
174173
bool isOverlayOfClangModule(ModuleDecl *swiftModule);
175174

176175
/// Check for cases where we have a fake cycle through an overlay.

‎lib/FrontendTool/TBD.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,8 @@ bool swift::writeTBD(ModuleDecl *M, StringRef OutputFilename,
6767
static bool isSymbolIgnored(const StringRef& name,
6868
const llvm::Module &IRModule) {
6969
if (llvm::Triple(IRModule.getTargetTriple()).isOSWindows()) {
70-
// (SR-15938) Error when referencing #dsohandle in a Swift test on Windows
70+
// https://github.com/apple/swift/issues/58199
71+
// Error when referencing #dsohandle in a Swift test on Windows.
7172
// On Windows, ignore the lack of __ImageBase in the TBD file.
7273
if (name == "__ImageBase") {
7374
return true;

‎lib/IDE/SourceEntityWalker.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -329,7 +329,7 @@ SemaAnnotator::walkToArgumentListPre(ArgumentList *ArgList) {
329329
if (ArgList->isImplicit())
330330
return Action::Continue(ArgList);
331331

332-
// FIXME: What about SubscriptExpr and KeyPathExpr arg labels? (SR-15063)
332+
// FIXME: What about SubscriptExpr and KeyPathExpr arg labels? (https://github.com/apple/swift/issues/57390)
333333
if (auto CallE = dyn_cast_or_null<CallExpr>(Parent.getAsExpr())) {
334334
if (!passCallArgNames(CallE->getFn(), ArgList))
335335
return doStopTraversal();

‎lib/IRGen/IRGen.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -181,8 +181,8 @@ swift::getIRTargetOptions(const IRGenOptions &Opts, ASTContext &Ctx) {
181181

182182
auto *Clang = static_cast<ClangImporter *>(Ctx.getClangModuleLoader());
183183

184-
// WebAssembly doesn't support atomics yet, see https://bugs.swift.org/browse/SR-12097
185-
// for more details.
184+
// WebAssembly doesn't support atomics yet, see
185+
// https://github.com/apple/swift/issues/54533 for more details.
186186
if (Clang->getTargetInfo().getTriple().isOSBinFormatWasm())
187187
TargetOpts.ThreadModel = llvm::ThreadModel::Single;
188188

‎lib/IRGen/IRGenDebugInfo.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -909,7 +909,7 @@ class IRGenDebugInfoImpl : public IRGenDebugInfo {
909909
Mangle::ASTMangler Mangler;
910910
std::string Result = Mangler.mangleTypeForDebugger(Ty, Sig);
911911

912-
// TODO(SR-15377): We currently cannot round trip some C++ types.
912+
// TODO: We currently cannot round trip some C++ types. (https://github.com/apple/swift/issues/57699)
913913
if (!Opts.DisableRoundTripDebugTypes &&
914914
!Ty->getASTContext().LangOpts.EnableCXXInterop) {
915915
// Make sure we can reconstruct mangled types for the debugger.

‎lib/Parse/Lexer.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1252,7 +1252,7 @@ static bool maybeConsumeNewlineEscape(const char *&CurPtr, ssize_t Offset) {
12521252
static bool diagnoseZeroWidthMatchAndAdvance(char Target, const char *&CurPtr,
12531253
DiagnosticEngine *Diags) {
12541254
// TODO: Detect, diagnose and skip over zero-width characters if required.
1255-
// See https://bugs.swift.org/browse/SR-8678 for possible implementation.
1255+
// See https://github.com/apple/swift/issues/51192 for possible implementation.
12561256
return *CurPtr == Target && CurPtr++;
12571257
}
12581258

‎lib/Parse/ParseDecl.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7343,7 +7343,7 @@ Parser::parseDeclVar(ParseDeclOptions Flags,
73437343
// Skip parsing the var-get-set clause if '{' is at start of line
73447344
// and next token is not 'didSet' or 'willSet'. Parsing as 'do'
73457345
// statement gives useful errors for missing 'do' before brace.
7346-
// See SR-14836.
7346+
// See https://github.com/apple/swift/issues/57183.
73477347
if (!PatternInit || !Tok.isAtStartOfLine() || isStartOfGetSetAccessor()) {
73487348
HasAccessors = true;
73497349
auto boundVar = parseDeclVarGetSet(

‎lib/Parse/ParseExpr.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1145,7 +1145,7 @@ static MagicIdentifierLiteralExpr::Kind
11451145
getMagicIdentifierLiteralKind(tok Kind, const LangOptions &Opts) {
11461146
switch (Kind) {
11471147
case tok::pound_file:
1148-
// TODO: Enable by default at the next source break. (SR-13199)
1148+
// TODO: Enable by default at the next source break. (https://github.com/apple/swift/issues/55639)
11491149
return Opts.hasFeature(Feature::ConciseMagicFile)
11501150
? MagicIdentifierLiteralExpr::FileIDSpelledAsFile
11511151
: MagicIdentifierLiteralExpr::FilePathSpelledAsFile;

‎lib/Parse/ParsePattern.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -434,7 +434,7 @@ Parser::parseParameterClause(SourceLoc &leftParenLoc,
434434
// warn about the misuse of this syntax and offer to
435435
// fix it.
436436
// An exception to this rule is when the type is declared with type sugar
437-
// Reference: SR-11724
437+
// Reference: https://github.com/apple/swift/issues/54133
438438
if (isa<OptionalTypeRepr>(param.Type)
439439
|| isa<ImplicitlyUnwrappedOptionalTypeRepr>(param.Type)) {
440440
diagnose(typeStartLoc, diag::parameter_unnamed)

‎lib/SIL/IR/SILDeclRef.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1035,7 +1035,7 @@ std::string SILDeclRef::mangle(ManglingKind MKind) const {
10351035
}
10361036

10371037
// Returns true if the given JVP/VJP SILDeclRef requires a new vtable entry.
1038-
// FIXME(SR-14131): Also consider derived declaration `@derivative` attributes.
1038+
// FIXME: Also consider derived declaration `@derivative` attributes. (https://github.com/apple/swift/issues/54833)
10391039
static bool derivativeFunctionRequiresNewVTableEntry(SILDeclRef declRef) {
10401040
assert(declRef.getDerivativeFunctionIdentifier() &&
10411041
"Expected a derivative function SILDeclRef");

‎lib/SIL/IR/ValueOwnership.cpp

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -194,16 +194,12 @@ CONSTANT_OR_NONE_OWNERSHIP_INST(Owned, MarkUninitialized)
194194
// be compatible so that TBAA doesn't allow the destroy to be hoisted above uses
195195
// of the cast, or the programmer must use Builtin.fixLifetime.
196196
//
197-
// FIXME
198-
// -----
199-
//
200-
// SR-7175: Since we model this as unowned, then we must copy the
201-
// value before use. This directly contradicts the semantics mentioned
202-
// above since we will copy the value upon any use lest we use an
203-
// unowned value in an owned or guaranteed way. So really all we will
204-
// do here is perhaps add a copy slightly earlier unless the unowned
205-
// value immediately is cast to something trivial. In such a case, we
206-
// should be able to simplify the cast to just a trivial value and
197+
// FIXME: Since we model this as unowned, then we must copy the value before use. (https://github.com/apple/swift/issues/49723)
198+
// This directly contradicts the semantics mentioned above since we will copy
199+
// the value upon any use lest we use an unowned value in an owned or guaranteed
200+
// way. So really all we will do here is perhaps add a copy slightly earlier
201+
// unless the unowned value immediately is cast to something trivial. In such a
202+
// case, we should be able to simplify the cast to just a trivial value and
207203
// then eliminate the copy. That being said, we should investigate
208204
// this since this is used in reinterpret_cast which is important from
209205
// a performance perspective.

‎lib/SILGen/SILGenBuiltin.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1152,7 +1152,7 @@ static ManagedValue emitBuiltinAutoDiffApplyDerivativeFunction(
11521152
AutoDiffDerivativeFunctionKind kind, unsigned arity,
11531153
bool throws, SILGenFunction &SGF, SILLocation loc,
11541154
SubstitutionMap substitutions, ArrayRef<ManagedValue> args, SGFContext C) {
1155-
// FIXME(SR-11853): Support throwing functions.
1155+
// FIXME: Support throwing functions. (https://github.com/apple/swift/issues/54259)
11561156
assert(!throws && "Throwing functions are not yet supported");
11571157

11581158
auto origFnVal = args[0].getValue();
@@ -1221,7 +1221,7 @@ static ManagedValue emitBuiltinAutoDiffApplyDerivativeFunction(
12211221
static ManagedValue emitBuiltinAutoDiffApplyTransposeFunction(
12221222
unsigned arity, bool throws, SILGenFunction &SGF, SILLocation loc,
12231223
SubstitutionMap substitutions, ArrayRef<ManagedValue> args, SGFContext C) {
1224-
// FIXME(SR-11853): Support throwing functions.
1224+
// FIXME: Support throwing functions. (https://github.com/apple/swift/issues/54259)
12251225
assert(!throws && "Throwing functions are not yet supported");
12261226

12271227
auto origFnVal = args.front().getValue();

‎lib/SILOptimizer/Differentiation/Common.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ bool isSemanticMemberAccessor(SILFunction *original) {
7171
if (!accessor)
7272
return false;
7373
// Currently, only getters and setters are supported.
74-
// TODO(SR-12640): Support `modify` accessors.
74+
// TODO: Support `modify` accessors (https://github.com/apple/swift/issues/55084)
7575
if (accessor->getAccessorKind() != AccessorKind::Get &&
7676
accessor->getAccessorKind() != AccessorKind::Set)
7777
return false;

‎lib/SILOptimizer/Differentiation/PullbackCloner.cpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -231,8 +231,7 @@ class PullbackCloner::Implementation final
231231
// $L | address-only | address, $*A' (no alternative)
232232
// $*A | address-only | address, $*A' (no alternative)
233233

234-
// TODO(SR-13077): Make "tangent value category" depend solely on whether
235-
// the tangent type is loadable or address-only.
234+
// TODO: Make tangent value category depend solely on whether the tangent type is loadable or address-only. (https://github.com/apple/swift/issues/55523)
236235
//
237236
// For loadable tangent types, using symbolic adjoint values instead of
238237
// concrete adjoint buffers is more efficient.
@@ -2599,7 +2598,7 @@ bool PullbackCloner::Implementation::runForSemanticMemberAccessor() {
25992598
return runForSemanticMemberGetter();
26002599
case AccessorKind::Set:
26012600
return runForSemanticMemberSetter();
2602-
// TODO(SR-12640): Support `modify` accessors.
2601+
// TODO: Support `modify` accessors. (https://github.com/apple/swift/issues/55084)
26032602
default:
26042603
llvm_unreachable("Unsupported accessor kind; inconsistent with "
26052604
"`isSemanticMemberAccessor`?");

‎lib/SILOptimizer/Mandatory/Differentiation.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1387,7 +1387,7 @@ void Differentiation::run() {
13871387
} else if (auto *lfi = dyn_cast<LinearFunctionInst>(&i)) {
13881388
// If linear map transposition is not enabled and an uncanonical
13891389
// `linear_function` instruction is encountered, emit a diagnostic.
1390-
// FIXME(SR-11850): Finish support for linear map transposition.
1390+
// FIXME: Finish support for linear map transposition. (https://github.com/apple/swift/issues/54256)
13911391
if (!EnableExperimentalLinearMapTransposition) {
13921392
if (!lfi->hasTransposeFunction()) {
13931393
astCtx.Diags.diagnose(

‎lib/Sema/CSApply.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6607,7 +6607,7 @@ Expr *ExprRewriter::coerceToType(Expr *expr, Type toType,
66076607
// foo(bar) // This expression should compile in Swift 3 mode
66086608
// ```
66096609
//
6610-
// See also: https://bugs.swift.org/browse/SR-6796
6610+
// See also: https://github.com/apple/swift/issues/49345
66116611
if (cs.getASTContext().isSwiftVersionAtLeast(4) &&
66126612
!cs.getASTContext().isSwiftVersionAtLeast(5)) {
66136613
auto obj1 = fromType->getOptionalObjectType();

0 commit comments

Comments
 (0)