Skip to content

Commit 5cbb3f7

Browse files
authored
Merge pull request #17862 from lorentey/crashes-scare-counters
[test] Fix test failures in optimized test runs
2 parents 955ac3b + 6c97fe4 commit 5cbb3f7

File tree

1 file changed

+2
-10
lines changed

1 file changed

+2
-10
lines changed

validation-test/stdlib/Dictionary.swift

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3421,8 +3421,6 @@ DictionaryTestSuite.test("BridgedToObjC.Verbatim.getObjects:andKeys:count:") {
34213421
for count in 0 ..< d.count + 2 {
34223422
checkGetObjectsAndKeys(d, count: count)
34233423
}
3424-
expectCrashLater()
3425-
checkGetObjectsAndKeys(d, count: -1)
34263424
}
34273425

34283426
//===---
@@ -3431,9 +3429,7 @@ DictionaryTestSuite.test("BridgedToObjC.Verbatim.getObjects:andKeys:count:") {
34313429
// Key type and value type are bridged non-verbatim.
34323430
//===---
34333431

3434-
DictionaryTestSuite.test("BridgedToObjC.KeyValue_ValueTypesCustomBridged")
3435-
.skip(.always("rdar://problem/41871587"))
3436-
.code {
3432+
DictionaryTestSuite.test("BridgedToObjC.KeyValue_ValueTypesCustomBridged") {
34373433
let d = getBridgedNSDictionaryOfKeyValue_ValueTypesCustomBridged()
34383434
let enumerator = d.keyEnumerator()
34393435

@@ -3530,8 +3526,6 @@ DictionaryTestSuite.test("BridgedToObjC.Custom.getObjects:andKeys:count:") {
35303526
for count in 0 ..< d.count + 2 {
35313527
checkGetObjectsAndKeys(d, count: count)
35323528
}
3533-
expectCrashLater()
3534-
checkGetObjectsAndKeys(d, count: -1)
35353529
}
35363530

35373531
func getBridgedNSDictionaryOfKey_ValueTypeCustomBridged() -> NSDictionary {
@@ -3549,9 +3543,7 @@ func getBridgedNSDictionaryOfKey_ValueTypeCustomBridged() -> NSDictionary {
35493543
return bridged
35503544
}
35513545

3552-
DictionaryTestSuite.test("BridgedToObjC.Key_ValueTypeCustomBridged")
3553-
.skip(.always("rdar://problem/41871587"))
3554-
.code {
3546+
DictionaryTestSuite.test("BridgedToObjC.Key_ValueTypeCustomBridged") {
35553547
let d = getBridgedNSDictionaryOfKey_ValueTypeCustomBridged()
35563548
let enumerator = d.keyEnumerator()
35573549

0 commit comments

Comments
 (0)