Merge pull request #60973 from lorentey/fix-modify-implementations

[stdlib] _modify: Ensure cleanup is always executed

Author: lorentey

stdlib/public/core/Array.swift

@@ -751,8 +751,8 @@ extension Array: RandomAccessCollection, MutableCollection {
       _makeMutableAndUnique() // makes the array native, too
       _checkSubscript_mutating(index)
       let address = _buffer.mutableFirstElementAddress + index
+      defer { _endMutation() }
       yield &address.pointee
-      _endMutation();
     }
   }
 

stdlib/public/core/ArraySlice.swift

@@ -546,8 +546,8 @@ extension ArraySlice: RandomAccessCollection, MutableCollection {
       _makeMutableAndUnique() // makes the array native, too
       _checkSubscript_native(index)
       let address = _buffer.subscriptBaseAddress + index
+      defer { _endMutation() }
       yield &address.pointee
-      _endMutation();
     }
   }
 

stdlib/public/core/ContiguousArray.swift

@@ -409,8 +409,8 @@ extension ContiguousArray: RandomAccessCollection, MutableCollection {
       _makeMutableAndUnique()
       _checkSubscript_mutating(index)
       let address = _buffer.mutableFirstElementAddress + index
+      defer { _endMutation() }
       yield &address.pointee
-      _endMutation();
     }
   }