SIL Bridging: use bool for boolean properties

This was a leftover from the time we didn't use C++ interop

Author: eeckstein

SwiftCompilerSources/Sources/SIL/Instruction.swift

@@ -236,10 +236,10 @@ final public class CopyAddrInst : Instruction {
   public var destination: Value { return destinationOperand.value }
 
   public var isTakeOfSrc: Bool {
-    bridged.CopyAddrInst_isTakeOfSrc() != 0
+    bridged.CopyAddrInst_isTakeOfSrc()
   }
   public var isInitializationOfDest: Bool {
-    bridged.CopyAddrInst_isInitializationOfDest() != 0
+    bridged.CopyAddrInst_isInitializationOfDest()
   }
 }
 
@@ -534,7 +534,7 @@ final public class RefElementAddrInst : SingleValueInstruction, UnaryInstruction
   public var instance: Value { operand.value }
   public var fieldIndex: Int { bridged.RefElementAddrInst_fieldIndex() }
 
-  public var fieldIsLet: Bool { bridged.RefElementAddrInst_fieldIsLet() != 0 }
+  public var fieldIsLet: Bool { bridged.RefElementAddrInst_fieldIsLet() }
 }
 
 final public class RefTailAddrInst : SingleValueInstruction, UnaryInstruction {
@@ -664,7 +664,7 @@ class ClassifyBridgeObjectInst : SingleValueInstruction, UnaryInstruction {}
 
 final public class PartialApplyInst : SingleValueInstruction, ApplySite {
   public var numArguments: Int { bridged.PartialApplyInst_numArguments() }
-  public var isOnStack: Bool { bridged.PartialApplyInst_isOnStack() != 0 }
+  public var isOnStack: Bool { bridged.PartialApplyInst_isOnStack() }
 
   public func calleeArgIndex(callerArgIndex: Int) -> Int {
     bridged.PartialApply_getCalleeArgIndexOfFirstAppliedArg() + callerArgIndex
@@ -719,13 +719,14 @@ class MarkMustCheckInst : SingleValueInstruction, UnaryInstruction {}
 public protocol Allocation : SingleValueInstruction { }
 
 final public class AllocStackInst : SingleValueInstruction, Allocation {
+  public var hasDynamicLifetime: Bool { bridged.AllocStackInst_hasDynamicLifetime() }
 }
 
 public class AllocRefInstBase : SingleValueInstruction, Allocation {
-  final public var isObjC: Bool { bridged.AllocRefInstBase_isObjc() != 0 }
+  final public var isObjC: Bool { bridged.AllocRefInstBase_isObjc() }
 
   final public var canAllocOnStack: Bool {
-    bridged.AllocRefInstBase_canAllocOnStack() != 0
+    bridged.AllocRefInstBase_canAllocOnStack()
   }
 }
 

include/swift/SIL/SILBridging.h

@@ -246,7 +246,7 @@ struct BridgedFunction {
   }
 
   bool hasSemanticsAttr(llvm::StringRef attrName) const {
-    return getFunction()->hasSemanticsAttr(attrName) ? 1 : 0;
+    return getFunction()->hasSemanticsAttr(attrName);
   }
 
   swift::EffectsKind getEffectAttribute() const {
@@ -538,7 +538,7 @@ struct BridgedInstruction {
     return getAs<swift::RefElementAddrInst>()->getFieldIndex();
   }
 
-  SwiftInt RefElementAddrInst_fieldIsLet() const {
+  bool RefElementAddrInst_fieldIsLet() const {
     return getAs<swift::RefElementAddrInst>()->getField()->isLet();
   }
 
@@ -569,15 +569,19 @@ struct BridgedInstruction {
     return swift::ApplySite(getInst()).getCalleeArgIndexOfFirstAppliedArg();
   }
 
-  SwiftInt PartialApplyInst_isOnStack() const {
-    return getAs<swift::PartialApplyInst>()->isOnStack() ? 1 : 0;
+  bool PartialApplyInst_isOnStack() const {
+    return getAs<swift::PartialApplyInst>()->isOnStack();
   }
 
-  SwiftInt AllocRefInstBase_isObjc() const {
+  bool AllocStackInst_hasDynamicLifetime() const {
+    return getAs<swift::AllocStackInst>()->hasDynamicLifetime();
+  }
+
+  bool AllocRefInstBase_isObjc() const {
     return getAs<swift::AllocRefInstBase>()->isObjC();
   }
 
-  SwiftInt AllocRefInstBase_canAllocOnStack() const {
+  bool AllocRefInstBase_canAllocOnStack() const {
     return getAs<swift::AllocRefInstBase>()->canAllocOnStack();
   }
 
@@ -613,12 +617,12 @@ struct BridgedInstruction {
     return getAs<swift::BeginAccessInst>()->getEnforcement() == swift::SILAccessEnforcement::Static;
   }
 
-  SwiftInt CopyAddrInst_isTakeOfSrc() const {
-    return getAs<swift::CopyAddrInst>()->isTakeOfSrc() ? 1 : 0;
+  bool CopyAddrInst_isTakeOfSrc() const {
+    return getAs<swift::CopyAddrInst>()->isTakeOfSrc();
   }
 
-  SwiftInt CopyAddrInst_isInitializationOfDest() const {
-    return getAs<swift::CopyAddrInst>()->isInitializationOfDest() ? 1 : 0;
+  bool CopyAddrInst_isInitializationOfDest() const {
+    return getAs<swift::CopyAddrInst>()->isInitializationOfDest();
   }
 
   void RefCountingInst_setIsAtomic(bool isAtomic) const {