Add unreachable in readLoc

usama54321 · usama54321 · commit 5ee55ea56689 · 2025-02-19T19:48:06.000-08:00
diff --git a/lib/Serialization/DeserializeSIL.cpp b/lib/Serialization/DeserializeSIL.cpp
@@ -430,9 +430,7 @@ SILDeserializer::readLoc(unsigned kind, SmallVectorImpl<uint64_t> &scratch) {
   case SILLocation::RegularKind:
     return RegularLocation(FNameLoc, Implicit);
   }
-
-  // LocationKind was not a recognized SILLocation::LocationKind.
-  return std::nullopt;
+  llvm_unreachable("Invalid LocationKind");
 }
 
 llvm::Expected<const SILDebugScope *>

Original file line number	Diff line number	Diff line change
`@@ -430,9 +430,7 @@ SILDeserializer::readLoc(unsigned kind, SmallVectorImpl<uint64_t> &scratch) {`
`430`	`430`	`case SILLocation::RegularKind:`
`431`	`431`	`return RegularLocation(FNameLoc, Implicit);`
`432`	`432`	`}`
`433`		`-`
`434`		`- // LocationKind was not a recognized SILLocation::LocationKind.`
`435`		`- return std::nullopt;`
	`433`	`+ llvm_unreachable("Invalid LocationKind");`
`436`	`434`	`}`
`437`	`435`
`438`	`436`	`llvm::Expected<const SILDebugScope *>`