Don't call strdup() if the symbol name was not resolvable

grynspan · grynspan · commit 5f0136fa6bf3 · 2022-12-10T12:02:30.000-05:00
diff --git a/stdlib/public/runtime/ReflectionMirror.cpp b/stdlib/public/runtime/ReflectionMirror.cpp
@@ -1117,7 +1117,7 @@ id swift_reflectionMirror_quickLookObject(OpaqueValue *value, const Metadata *T)
 SWIFT_CC(swift) SWIFT_RUNTIME_STDLIB_INTERNAL
 const char *swift_keyPath_copySymbolName(void *address) {
   SymbolInfo info;
-  if (lookupSymbol(address, &info)) {
+  if (lookupSymbol(address, &info) && info.getSymbolName()) {
     return strdup(info.getSymbolName());
   }
   return 0;

Original file line number	Diff line number	Diff line change
`@@ -1117,7 +1117,7 @@ id swift_reflectionMirror_quickLookObject(OpaqueValue value, const Metadata T)`
`1117`	`1117`	`SWIFT_CC(swift) SWIFT_RUNTIME_STDLIB_INTERNAL`
`1118`	`1118`	`const char swift_keyPath_copySymbolName(void address) {`
`1119`	`1119`	`SymbolInfo info;`
`1120`		`- if (lookupSymbol(address, &info)) {`
	`1120`	`+ if (lookupSymbol(address, &info) && info.getSymbolName()) {`
`1121`	`1121`	`return strdup(info.getSymbolName());`
`1122`	`1122`	`}`
`1123`	`1123`	`return 0;`