[IRGen] Determine whether protocol requirement is async using SILDeclRef

While building witness table record, let's use `hasAsync()` check on
`SILDeclRef` of the requirement instead of reaching for the underlying
declaration because the reference should be the source of truth about
`async` and other attributes.

In case of distributed thunk witness, which is always `async throws`,
the underlying declaration could be sync because it's the protocol
requirement declaration.

Author: xedin

0002-IRGen-Mark-proptocol-requirement-descriptor-for-dist.patch

@@ -0,0 +1,33 @@
+From 4283c7d83c1514d659ffa9faf7e192a6ce6ab5c1 Mon Sep 17 00:00:00 2001
+From: Pavel Yaskevich <[email protected]>
+Date: Thu, 21 Jul 2022 14:10:49 -0700
+Subject: [PATCH 2/3] [IRGen] Mark proptocol requirement descriptor for
+ distributed thunk as async
+
+Fixes a bug where descriptor for protocol requirement associated with
+distributed thunk wasn't marked as `async` that results in ptrauth failures
+because discriminator would be misaligned between requirement and witness.
+
+Resolves: rdar://96520492
+---
+ lib/IRGen/GenMeta.cpp | 4 ++++
+ 1 file changed, 4 insertions(+)
+
+diff --git a/lib/IRGen/GenMeta.cpp b/lib/IRGen/GenMeta.cpp
+index 47e5aa665c5..7389500fe6f 100644
+--- a/lib/IRGen/GenMeta.cpp
++++ b/lib/IRGen/GenMeta.cpp
+@@ -915,6 +915,10 @@ namespace {
+         if (entry.getFunction().isAutoDiffDerivativeFunction())
+           declRef = declRef.asAutoDiffDerivativeFunction(
+               entry.getFunction().getAutoDiffDerivativeFunctionIdentifier());
++        if (entry.getFunction().isDistributedThunk()) {
++          flags = flags.withIsAsync(true);
++          declRef = declRef.asDistributed();
++        }
+         addDiscriminator(flags, schema, declRef);
+       }
+ 
+-- 
+2.32.2 (Apple Git-134)
+

lib/IRGen/GenProto.cpp

@@ -1352,6 +1352,8 @@ class AccessorConformanceInfo : public ConformanceInfo {
       auto &entry = SILEntries.front();
       SILEntries = SILEntries.slice(1);
 
+      bool isAsyncRequirement = requirement.hasAsync();
+
 #ifndef NDEBUG
       assert(entry.getKind() == SILWitnessTable::Method
              && "sil witness table does not match protocol");
@@ -1364,10 +1366,9 @@ class AccessorConformanceInfo : public ConformanceInfo {
 #endif
 
       SILFunction *Func = entry.getMethodWitness().Witness;
-      auto *afd = cast<AbstractFunctionDecl>(
-          entry.getMethodWitness().Requirement.getDecl());
       llvm::Constant *witness = nullptr;
       if (Func) {
+        assert(Func->isAsync() == isAsyncRequirement);
         if (Func->isAsync()) {
           witness = IGM.getAddrOfAsyncFunctionPointer(Func);
         } else {
@@ -1376,7 +1377,7 @@ class AccessorConformanceInfo : public ConformanceInfo {
       } else {
         // The method is removed by dead method elimination.
         // It should be never called. We add a pointer to an error function.
-        if (afd->hasAsync()) {
+        if (isAsyncRequirement) {
           witness = llvm::ConstantExpr::getBitCast(
               IGM.getDeletedAsyncMethodErrorAsyncFunctionPointer(),
               IGM.FunctionPtrTy);
@@ -1388,8 +1389,9 @@ class AccessorConformanceInfo : public ConformanceInfo {
       witness = llvm::ConstantExpr::getBitCast(witness, IGM.Int8PtrTy);
 
       PointerAuthSchema schema =
-          afd->hasAsync() ? IGM.getOptions().PointerAuth.AsyncProtocolWitnesses
-                          : IGM.getOptions().PointerAuth.ProtocolWitnesses;
+          isAsyncRequirement
+              ? IGM.getOptions().PointerAuth.AsyncProtocolWitnesses
+              : IGM.getOptions().PointerAuth.ProtocolWitnesses;
       Table.addSignedPointer(witness, schema, requirement);
       return;
     }