Merge pull request #17203 from jckarter/rvalue-array-elements

Sema: Force the 'getElements' array of a type-checked ArrayExpr to contain rvalues.

Author: jckarter

lib/Sema/CSApply.cpp

@@ -2988,6 +2988,14 @@ namespace {
       DeclName name(tc.Context, DeclBaseName::createConstructor(),
                     { tc.Context.Id_arrayLiteral });
 
+      // Coerce the array elements to be rvalues, so that other type-checker
+      // code that attempts to peephole the AST doesn't have to re-load the
+      // elements (and break the invariant that lvalue nodes only get their
+      // access kind set once).
+      for (auto &element : expr->getElements()) {
+        element = cs.coerceToRValue(element);
+      }
+
       // Restructure the argument to provide the appropriate labels in the
       // tuple.
       SmallVector<TupleTypeElt, 4> typeElements;

test/expr/cast/objc_coerce_array.swift

@@ -0,0 +1,7 @@
+// RUN: %target-swift-frontend(mock-sdk: %clang-importer-sdk) -emit-silgen -verify %s
+// REQUIRES: objc_interop
+import Foundation
+
+var x = 1
+
+_ = [x] as [NSNumber]