Skip to content

Commit 6389774

Browse files
committed
Remove SharedTimer Infrastructure
Teach the UnifiedStatsReporter to directly construct llvm::NamedRegionTimer for itself.
1 parent 2198d71 commit 6389774

File tree

13 files changed

+3
-98
lines changed

13 files changed

+3
-98
lines changed

include/swift/Basic/Statistic.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515

1616
#include "llvm/ADT/SmallString.h"
1717
#include "llvm/ADT/Statistic.h"
18+
#include "llvm/Support/Timer.h"
1819
#include "swift/Basic/LLVM.h"
19-
#include "swift/Basic/Timer.h"
2020

2121
#include <thread>
2222
#include <tuple>

include/swift/Basic/Timer.h

Lines changed: 0 additions & 66 deletions
This file was deleted.

lib/Basic/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,6 @@ add_swift_host_library(swiftBasic STATIC
6262
StringExtras.cpp
6363
TaskQueue.cpp
6464
ThreadSafeRefCounted.cpp
65-
Timer.cpp
6665
Unicode.cpp
6766
UUID.cpp
6867
Version.cpp

lib/Basic/Statistic.cpp

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
#include "clang/Basic/SourceLocation.h"
1515
#include "clang/Basic/SourceManager.h"
1616
#include "swift/Basic/Statistic.h"
17-
#include "swift/Basic/Timer.h"
1817
#include "swift/AST/Decl.h"
1918
#include "swift/AST/Expr.h"
2019
#include "llvm/ADT/DenseMap.h"
@@ -146,9 +145,8 @@ auxName(StringRef ModuleName,
146145
}
147146

148147
class UnifiedStatsReporter::RecursionSafeTimers {
149-
150148
struct RecursionSafeTimer {
151-
llvm::Optional<SharedTimer> Timer;
149+
llvm::Optional<llvm::NamedRegionTimer> Timer;
152150
size_t RecursionDepth;
153151
};
154152

@@ -159,7 +157,7 @@ class UnifiedStatsReporter::RecursionSafeTimers {
159157
void beginTimer(StringRef Name) {
160158
RecursionSafeTimer &T = Timers[Name];
161159
if (T.RecursionDepth == 0) {
162-
T.Timer.emplace(Name);
160+
T.Timer.emplace(Name, Name, "swift", "Swift compilation");
163161
}
164162
++T.RecursionDepth;
165163
}
@@ -354,7 +352,6 @@ UnifiedStatsReporter::UnifiedStatsReporter(StringRef ProgramName,
354352
path::append(TraceFilename, makeTraceFileName(ProgramName, AuxName));
355353
path::append(ProfileDirname, makeProfileDirName(ProgramName, AuxName));
356354
EnableStatistics(/*PrintOnExit=*/false);
357-
SharedTimer::enableCompilationTimers();
358355
if (TraceEvents || ProfileEvents || ProfileEntities)
359356
LastTracedFrontendCounters.emplace();
360357
if (TraceEvents)

lib/Basic/Timer.cpp

Lines changed: 0 additions & 17 deletions
This file was deleted.

lib/FrontendTool/FrontendTool.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@
4545
#include "swift/Basic/PrettyStackTrace.h"
4646
#include "swift/Basic/SourceManager.h"
4747
#include "swift/Basic/Statistic.h"
48-
#include "swift/Basic/Timer.h"
4948
#include "swift/Basic/UUID.h"
5049
#include "swift/Frontend/DiagnosticVerifier.h"
5150
#include "swift/Frontend/Frontend.h"

lib/IRGen/IRGen.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
#include "swift/Basic/Dwarf.h"
2727
#include "swift/Basic/Platform.h"
2828
#include "swift/Basic/Statistic.h"
29-
#include "swift/Basic/Timer.h"
3029
#include "swift/Basic/Version.h"
3130
#include "swift/ClangImporter/ClangImporter.h"
3231
#include "swift/ClangImporter/ClangModule.h"

lib/Parse/Parser.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
#include "swift/AST/SourceFile.h"
2525
#include "swift/Basic/Defer.h"
2626
#include "swift/Basic/SourceManager.h"
27-
#include "swift/Basic/Timer.h"
2827
#include "swift/Parse/Lexer.h"
2928
#include "swift/Parse/CodeCompletionCallbacks.h"
3029
#include "swift/Parse/ParseSILSupport.h"

lib/SIL/Parser/ParseSIL.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
#include "swift/AST/SourceFile.h"
2222
#include "swift/AST/TypeCheckRequests.h"
2323
#include "swift/Basic/Defer.h"
24-
#include "swift/Basic/Timer.h"
2524
#include "swift/Demangling/Demangle.h"
2625
#include "swift/Parse/Lexer.h"
2726
#include "swift/Parse/ParseSILSupport.h"

lib/SILGen/SILGen.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@
2929
#include "swift/AST/SourceFile.h"
3030
#include "swift/AST/TypeCheckRequests.h"
3131
#include "swift/Basic/Statistic.h"
32-
#include "swift/Basic/Timer.h"
3332
#include "swift/ClangImporter/ClangModule.h"
3433
#include "swift/SIL/PrettyStackTrace.h"
3534
#include "swift/SIL/SILArgument.h"

lib/Sema/TypeCheckCodeCompletion.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@
3939
#include "swift/AST/TypeCheckRequests.h"
4040
#include "swift/Basic/Statistic.h"
4141
#include "swift/Basic/STLExtras.h"
42-
#include "swift/Basic/Timer.h"
4342
#include "swift/Parse/Lexer.h"
4443
#include "swift/Sema/IDETypeChecking.h"
4544
#include "swift/Strings.h"

lib/Sema/TypeChecker.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@
3838
#include "swift/AST/TypeCheckRequests.h"
3939
#include "swift/Basic/Statistic.h"
4040
#include "swift/Basic/STLExtras.h"
41-
#include "swift/Basic/Timer.h"
4241
#include "swift/Parse/Lexer.h"
4342
#include "swift/Sema/IDETypeChecking.h"
4443
#include "swift/Strings.h"

lib/Serialization/Serialization.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@
3939
#include "swift/Basic/Dwarf.h"
4040
#include "swift/Basic/FileSystem.h"
4141
#include "swift/Basic/STLExtras.h"
42-
#include "swift/Basic/Timer.h"
4342
#include "swift/Basic/Version.h"
4443
#include "swift/ClangImporter/ClangImporter.h"
4544
#include "swift/ClangImporter/ClangModule.h"

0 commit comments

Comments
 (0)