---

yaml
---
r: 343230
b: refs/heads/master-rebranch
c: f1f75ca
h: refs/heads/master

Author: aschwaighofer

[refs]

@@ -1455,7 +1455,7 @@ refs/tags/swift-DEVELOPMENT-SNAPSHOT-2019-08-02-a: ddd2b2976aa9bfde5f20fe37f6bd2
 refs/tags/swift-DEVELOPMENT-SNAPSHOT-2019-08-03-a: 171cc166f2abeb5ca2a4003700a8a78a108bd300
 refs/heads/benlangmuir-patch-1: baaebaf39d52f3bf36710d4fe40cf212e996b212
 refs/heads/i-do-redeclare: 8c4e6d5de5c1e3f0a2cedccf319df713ea22c48e
-refs/heads/master-rebranch: 684213415224f8367c35734e8996d26d01e3202a
+refs/heads/master-rebranch: f1f75ca9f4ba0fad978f5944f02a3e3b1af69f35
 refs/heads/rdar-53901732: 9bd06af3284e18a109cdbf9aa59d833b24eeca7b
 refs/heads/revert-26776-subst-always-returns-a-type: 1b8e18fdd391903a348970a4c848995d4cdd789c
 refs/heads/tensorflow-merge: 8b854f62f80d4476cb383d43c4aac2001dde3cec

branches/master-rebranch/lib/Parse/ParseType.cpp

@@ -391,6 +391,7 @@ Parser::TypeASTResult Parser::parseType(Diag<> MessageID,
   }
 
   if (Tok.is(tok::arrow)) {
+    auto InputNode = SyntaxContext->popIf<ParsedTypeSyntax>().getValue();
     // Handle type-function if we have an arrow.
     auto ArrowLoc = Tok.getLoc();
     auto Arrow = consumeTokenSyntax();
@@ -403,23 +404,21 @@ Parser::TypeASTResult Parser::parseType(Diag<> MessageID,
     }
     ParserResult<TypeRepr> SecondHalf =
         parseType(diag::expected_type_function_result);
+    auto SecondTy = SyntaxContext->popIf<ParsedTypeSyntax>();
     if (SecondHalf.isParseError()) {
+      SyntaxContext->addSyntax(InputNode);
       if (Throws)
         SyntaxContext->addSyntax(*Throws);
       SyntaxContext->addSyntax(Arrow);
+      if (SecondTy)
+        SyntaxContext->addSyntax(*SecondTy);
       if (SecondHalf.hasCodeCompletion())
         return makeParserCodeCompletionResult<TypeRepr>();
       if (SecondHalf.isNull())
         return nullptr;
     }
 
     ParsedFunctionTypeSyntaxBuilder Builder(*SyntaxContext);
-    Builder.useReturnType(SyntaxContext->popIf<ParsedTypeSyntax>().getValue());
-    Builder.useArrow(Arrow);
-    if (Throws)
-      Builder.useThrowsOrRethrowsKeyword(*Throws);
-
-    auto InputNode = SyntaxContext->popIf<ParsedTypeSyntax>().getValue();
     bool isVoid = false;
     if (auto TupleTypeNode = InputNode.getAs<ParsedTupleTypeSyntax>()) {
       // Decompose TupleTypeSyntax and repack into FunctionType.
@@ -447,6 +446,13 @@ Parser::TypeASTResult Parser::parseType(Diag<> MessageID,
       Builder.addArgumentsMember(ParsedSyntaxRecorder::makeTupleTypeElement(
           InputNode, /*TrailingComma=*/None, *SyntaxContext));
     }
+
+    Builder.useReturnType(*SecondTy);
+    if (Throws)
+      Builder.useThrowsOrRethrowsKeyword(*Throws);
+    Builder.useArrow(Arrow);
+    Builder.useReturnType(*SecondTy);
+
     SyntaxContext->addSyntax(Builder.build());
 
     auto FunctionType = SyntaxContext->topNode<FunctionTypeSyntax>();
@@ -1107,21 +1113,20 @@ Parser::TypeResult Parser::parseTypeTupleBody() {
     // Parse the type annotation.
     auto TypeLoc = Tok.getLoc();
     auto TypeASTResult = parseType(diag::expected_type);
+    auto Type = SyntaxContext->popIf<ParsedTypeSyntax>();
     if (TypeASTResult.hasCodeCompletion() || TypeASTResult.isNull()) {
       Junk.append(LocalJunk.begin(), LocalJunk.end());
-      if (auto parsedT = SyntaxContext->popIf<ParsedTypeSyntax>())
-        Junk.push_back(*parsedT);
+      if (Type)
+        Junk.push_back(*Type);
       skipListUntilDeclRBraceSyntax(Junk, LParenLoc, tok::r_paren, tok::comma);
       return TypeASTResult.hasCodeCompletion()
                  ? makeParserCodeCompletionStatus()
                  : makeParserError();
     }
 
-    auto Type = *SyntaxContext->popIf<ParsedTypeSyntax>();
-
     if (IsInOutObsoleted) {
       bool IsTypeAlreadyAttributed = false;
-      if (auto AttributedType = Type.getAs<ParsedAttributedTypeSyntax>())
+      if (auto AttributedType = Type->getAs<ParsedAttributedTypeSyntax>())
         IsTypeAlreadyAttributed = AttributedType->getDeferredSpecifier().hasValue();
 
       if (IsTypeAlreadyAttributed) {
@@ -1167,7 +1172,7 @@ Parser::TypeResult Parser::parseTypeTupleBody() {
     Comma = consumeTokenSyntaxIf(tok::comma);
 
     auto Element = ParsedSyntaxRecorder::makeTupleTypeElement(
-        InOut, Name, SecondName, Colon, Type, ElementEllipsis, Initializer,
+        InOut, Name, SecondName, Colon, *Type, ElementEllipsis, Initializer,
         Comma, *SyntaxContext);
 
     Junk.push_back(Element);

branches/master-rebranch/test/Frontend/dump-parse.swift

@@ -1,4 +1,4 @@
-// RUN: not %target-swift-frontend -dump-parse %s 2>&1 | %FileCheck %s
+// RUN: not %target-swift-frontend -dump-parse %s | %FileCheck %s
 // RUN: not %target-swift-frontend -dump-ast %s | %FileCheck %s -check-prefix=CHECK-AST
 
 // CHECK-LABEL: (func_decl{{.*}}"foo(_:)"

branches/master-rebranch/test/Syntax/round_trip_misc.swift

@@ -19,6 +19,9 @@ do {
 do {
   typealias Alias3 = (a b C, 
 }
+do {
+  typealias Alias3 = () -> @objc func
+}
 
 // Orphan '}' at top level
 }