Merge pull request #20538 from benlangmuir/disable-DiagsAfterCloseAndReopen

benlangmuir · web-flow · commit 646247369684 · 2018-11-13T11:53:33.000-08:00
[sourcekit] Disable DiagsAfterCloseAndReopen test (again)
diff --git a/unittests/SourceKit/SwiftLang/EditingTest.cpp b/unittests/SourceKit/SwiftLang/EditingTest.cpp
@@ -266,7 +266,8 @@ void EditTest::doubleOpenWithDelay(useconds_t delay, bool closeDoc) {
   close(DocName);
 }
 
-TEST_F(EditTest, DiagsAfterCloseAndReopen) {
+// This test is failing occassionally in CI: rdar://45644449
+TEST_F(EditTest, DISABLED_DiagsAfterCloseAndReopen) {
   // Attempt to open the same file twice in a row. This tests (subject to
   // timing) cases where:
   // * the 2nd open happens before the first AST starts building

Original file line number	Diff line number	Diff line change
`@@ -266,7 +266,8 @@ void EditTest::doubleOpenWithDelay(useconds_t delay, bool closeDoc) {`
`266`	`266`	`close(DocName);`
`267`	`267`	`}`
`268`	`268`
`269`		`-TEST_F(EditTest, DiagsAfterCloseAndReopen) {`
	`269`	`+// This test is failing occassionally in CI: rdar://45644449`
	`270`	`+TEST_F(EditTest, DISABLED_DiagsAfterCloseAndReopen) {`
`270`	`271`	`// Attempt to open the same file twice in a row. This tests (subject to`
`271`	`272`	`// timing) cases where:`
`272`	`273`	`// * the 2nd open happens before the first AST starts building`