Skip to content

Commit 64c3bd7

Browse files
committed
Fix an incorrect regex that matched more than it should
For example, the first regex matched the following text incorrectly (the `-filelist` argument matched until the first open double-quote in `"BUILD_DIR/\$(CONFIGURATION)...`). ```` BUILD_DIR/Debug/bin/swift -frontend -c -filelist /var/folders/.../sources-098836 -primary-filelist /var/folders/.../primaryInputs-b8aa5a -supplementary-output-file-map /var/folders/.../supplementaryOutputs-b1a037 -target x86_64-apple-macosx10.9 -enable-objc-interop -module-cache-path "BUILD_DIR/\$(CONFIGURATION)\$(EFFECTIVE_PLATFORM_NAME)/swift-test-results/x86_64-apple-macosx10.9/clang-module-cache" -swift-version 4 -module-name main -output-filelist /var/folders/.../outputs-c97286 ```` Also removes unused variables.
1 parent 39d3963 commit 64c3bd7

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

test/Driver/driver-compile.swift

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -118,14 +118,14 @@
118118
// DUPLICATE-NAME: note: filenames are used to distinguish private declarations with the same name
119119

120120
// FILELIST: bin/swift
121-
// FILELIST: -filelist [[SOURCES:(["][^"]+|[^ ]+)sources([^"]+["]|[^ ]+)]]
122-
// FILELIST: -primary-filelist [[PRIMARY_FILELIST:(["][^"]+|[^ ]+)primaryInputs([^"]+["]|[^ ]+)]]
123-
// FILELIST: -supplementary-output-file-map [[SUPPLEMENTARY_OUTPUT_FILEMAP:(["][^"]+|[^ ]+)supplementaryOutputs([^"]+["]|[^ ]+)]]
121+
// FILELIST: -filelist [[SOURCES:(["][^"]+sources[^"]+["]|[^ ]+sources[^ ]+)]]
122+
// FILELIST: -primary-filelist {{(["][^"]+primaryInputs[^"]+["]|[^ ]+primaryInputs[^ ]+)}}
123+
// FILELIST: -supplementary-output-file-map {{(["][^"]+supplementaryOutputs[^"]+["]|[^ ]+supplementaryOutputs[^ ]+)}}
124124
// FILELIST: -output-filelist {{[^-]}}
125125
// FILELIST-NEXT: bin/swift
126126
// FILELIST: -filelist [[SOURCES]]
127-
// FILELIST: -primary-filelist {{(["][^"]+|[^ ]+)primaryInputs([^"]+["]|[^ ]+)}}
128-
// FILELIST: -supplementary-output-file-map {{(["][^"]+|[^ ]+)supplementaryOutputs([^"]+["]|[^ ]+)}}
127+
// FILELIST: -primary-filelist {{(["][^"]+primaryInputs[^"]+["]|[^ ]+primaryInputs[^ ]+)}}
128+
// FILELIST: -supplementary-output-file-map {{(["][^"]+supplementaryOutputs[^"]+["]|[^ ]+supplementaryOutputs[^ ]+)}}
129129
// FILELIST: -output-filelist {{[^-]}}
130130

131131
// UPDATE-CODE: DISTINCTIVE-PATH/usr/bin/swift

0 commit comments

Comments
 (0)