Fixed no copying IsIsolated flag when cloning subscript params

Author: nickolas-pohilets

lib/AST/Decl.cpp

@@ -11105,16 +11105,16 @@ AccessorDecl *AccessorDecl::createParsed(
           subscriptParam->getArgumentNameLoc(),
           subscriptParam->getArgumentName(), subscriptParam->getNameLoc(),
           subscriptParam->getName(), /*declContext*/ accessor);
-      param->setAutoClosure(subscriptParam->isAutoClosure());
 
       // The cloned parameter is implicit.
       param->setImplicit();
 
-      if (subscriptParam->isSending())
-        param->setSending();
-
-      if (subscriptParam->isCallerIsolated())
-        param->setCallerIsolated();
+      // TODO: Check why IsVariadic is not copied.
+      param->setAutoClosure(subscriptParam->isAutoClosure());
+      param->setIsolated(subscriptParam->isIsolated());
+      // TODO: Check why IsAddressable is not copied.
+      param->setSending(subscriptParam->isSending());
+      param->setCallerIsolated(subscriptParam->isCallerIsolated());
 
       newParams.push_back(param);
     }

test/Concurrency/isolated_parameters.swift

@@ -8,7 +8,7 @@
 
 @available(SwiftStdlib 5.1, *)
 actor A {
-  func f() { } // expected-typechecker-note 5{{calls to instance method 'f()' from outside of its actor context are implicitly asynchronous}}
+  func f() { } // expected-typechecker-note 3{{calls to instance method 'f()' from outside of its actor context are implicitly asynchronous}}
 }
 
 @available(SwiftStdlib 5.1, *)
@@ -364,11 +364,8 @@ func isolatedClosures() {
   // expected-typechecker-warning@+2 {{cannot have more than one 'isolated' parameter; this is an error in the Swift 6 language mode}}
   // expected-typechecker-warning@+1 {{subscript with 'isolated' parameter cannot be 'nonisolated'; this is an error in the Swift 6 language mode}}{{3-15=}}
   nonisolated subscript(_ a: isolated A, _ b: isolated A) -> Int {
-    // FIXME: wrong isolation. should be isolated to `a`.
-    #if ALLOW_TYPECHECKER_ERRORS
-    a.f() // expected-typechecker-error {{call to actor-isolated instance method 'f()' in a synchronous actor-isolated context}}
-    b.f() // expected-typechecker-error {{call to actor-isolated instance method 'f()' in a synchronous actor-isolated context}}
-    #endif
+    a.f()
+    b.f()
     return 0
   }
 
@@ -591,3 +588,14 @@ public actor MyActorIsolatedParameterMerge {
 class ClassWithIsolatedAsyncInitializer {
     init(isolation: isolated (any Actor)? = #isolation) async {}
 }
+
+// https://github.com/swiftlang/swift/issues/80992
+struct WritableActorKeyPath<Root: Actor, Value>: Sendable {
+    var getter: @Sendable (isolated Root) -> Value
+    var setter: @Sendable (isolated Root, Value) -> Void
+
+    subscript(_ root: isolated Root) -> Value {
+        get { getter(root) }
+        nonmutating set { setter(root, newValue) }
+    }
+}