Merge pull request #11000 from rjmccall/keep-openings-opaque

Author: swift-ci

lib/SILGen/SILGenExpr.cpp

@@ -593,6 +593,11 @@ static BridgingConversion getBridgingConversion(Expr *E) {
     return { E, kind, 0 };
   }
 
+  // If we peeked through an opening, and we didn't recognize a specific
+  // pattern above involving the opaque value, make sure we use the opening
+  // as the final expression instead of accidentally look through it.
+  if (open) return { open, None, 0 };
+
   return { E, None, 0 };
 }
 

test/SILGen/objc_bridging_peephole.swift

@@ -472,3 +472,13 @@ func testNullproneSubscriptSet(object: NullproneSubscript, index: AnyObject) {
   // CHECK:      end_borrow [[SELF]] from %0
   object[index] = makeOptNS() as String?
 }
+
+/*** Bugfixes ***************************************************************/
+
+protocol P {
+  var title : String { get }
+}
+
+func foo(p: P) {
+  DummyClass().takeNullableString(p.title)
+}