Merge pull request #8741 from slavapestov/existential-layout-memory-messup

Fix a memory error introduced by recent changes

Author: slavapestov

lib/SILGen/SILGenPoly.cpp

@@ -163,8 +163,9 @@ namespace {
 static ArrayRef<ProtocolConformanceRef>
 collectExistentialConformances(ModuleDecl *M, CanType fromType, CanType toType) {
   assert(!fromType.isAnyExistentialType());
-  
-  auto protocols = toType.getExistentialLayout().getProtocols();
+
+  auto layout = toType.getExistentialLayout();
+  auto protocols = layout.getProtocols();
 
   SmallVector<ProtocolConformanceRef, 4> conformances;
   for (auto proto : protocols) {

lib/Sema/TypeCheckProtocol.cpp

@@ -5315,7 +5315,8 @@ TypeChecker::conformsToProtocol(Type T, ProtocolDecl *Proto, DeclContext *DC,
 
     if (T->isExistentialType()) {
       bool anyUnsatisfied = false;
-      for (auto *proto : T->getExistentialLayout().getProtocols()) {
+      auto layout = T->getExistentialLayout();
+      for (auto *proto : layout.getProtocols()) {
         auto *protoDecl = proto->getDecl();
         if ((*unsatisfiedDependency)(requestInheritedProtocols(protoDecl)))
           anyUnsatisfied = true;

lib/Sema/TypeCheckType.cpp

@@ -3941,7 +3941,8 @@ class UnsupportedProtocolVisitor
         if (T->isInvalid())
           return false;
         if (type->isExistentialType()) {
-          for (auto *proto : type->getExistentialLayout().getProtocols()) {
+          auto layout = type->getExistentialLayout();
+          for (auto *proto : layout.getProtocols()) {
             auto *protoDecl = proto->getDecl();
 
             if (protoDecl->existentialTypeSupported(&TC))