Reapply: Remove the last uses of ++/-- from the stdlib directory.

This reverts commit fc6a406.

Author: lattner

stdlib/private/StdlibUnittest/StdlibUnittest.swift.gyb

@@ -1499,9 +1499,9 @@ public func checkHashable<T : Hashable>(
     [lhs, rhs], equalityOracle: { expectedEqual || $0 == $1 }, ${trace})
 }
 
-% for inc, protocol, op, successor, end in (
-%  ('inc', '_Incrementable', '++', 'successor', 'end'),
-%  ('dec', 'BidirectionalIndexType', '--', 'predecessor', 'start')):
+% for inc, protocol, successor, end in (
+%  ('inc', '_Incrementable', 'successor', 'end'),
+%  ('dec', 'BidirectionalIndexType', 'predecessor', 'start')):
 
 /// Test that the elements of `instances` satisfy
 /// ${'some of ' if inc == 'dec' else ''}the semantic
@@ -1531,16 +1531,6 @@ public func check${inc.capitalize()}rementable<
       var j = i
       j._${successor}InPlace()
       expectEqual(j, next, ${trace})
-
-      // Post-${inc}rement works
-      j = i
-      expectEqual(j${op}, i, ${trace})
-      expectEqual(j, next, ${trace})
-
-      // Pre-${inc}rement works
-      j = i
-      expectEqual(${op}j, next, ${trace})
-      expectEqual(j, next, ${trace})
     }
   }
 }
@@ -1928,7 +1918,8 @@ public func checkSequence<
     expectTrue(end == buf + count, "_initializeTo returned the wrong value")
     var j = expected.startIndex
     for i in 0..<(end - buf) {
-      expectTrue(sameValue(expected[j++], buf[i]))
+      expectTrue(sameValue(expected[j], buf[i]))
+      j = j.successor()
     }
     buf.destroy(end - buf)
     buf.dealloc(count)
@@ -2018,7 +2009,7 @@ public func check${traversal}Collection<
     }
     else {
       for _ in 0..<n.toIntMax() {
-        ++i
+        i += 1
       }
     }
     return i
@@ -2064,9 +2055,9 @@ public func check${traversal}Collection<
       for i in 0..<allIndices.count-1 {
         let successor1 = allIndices[i].successor()
         var successor2 = allIndices[i]
-        successor2++
+        successor2 = successor2.successor()
         var successor3 = allIndices[i]
-        ++successor3
+        successor3 = successor3.successor()
         for s in [ successor1, successor2, successor3 ] {
           expectEqual(allIndices[i + 1], s, ${trace})
           expectEqual(
@@ -2088,8 +2079,8 @@ public func check${traversal}Collection<
       }
       for i in 1..<allIndices.count {
         var index = allIndices[i]
-        --index
-        ++index
+        index = index.predecessor()
+        index = index.successor()
         expectEqual(allIndices[i], index, ${trace})
         expectEqual(
           expectedArray[i], collection[index], ${trace}, sameValue: sameValue)
@@ -2160,29 +2151,29 @@ public func checkSliceableWithBidirectionalIndex<
   var start = sliceable.startIndex
   for startNumericIndex in 0...expectedArray.count {
     if start != sliceable.endIndex {
-      ++start
-      --start
-      ++start
-      --start
+      start = start.successor()
+      start = start.predecessor()
+      start = start.successor()
+      start = start.predecessor()
     }
     var end = start
     for endNumericIndex in startNumericIndex...expectedArray.count {
       if end != sliceable.endIndex {
-        ++end
-        --end
-        ++end
-        --end
+        end = end.successor()
+        end = end.predecessor()
+        end = end.successor()
+        end = end.predecessor()
       }
       let expectedSlice = expectedArray[startNumericIndex..<endNumericIndex]
       let slice = sliceable[start..<end]
       checkBidirectionalCollection(expectedSlice, slice, ${trace})
 
       if end != sliceable.endIndex {
-        ++end
+        end = end.successor()
       }
     }
     if start != sliceable.endIndex {
-      ++start
+      end = end.successor()
     }
   }
 }