[Type checker] Move ad-hoc isObjC/isDynamic checking to finalization.

Whenever we visit a declaration via the DeclChecker, add it to the
list of declarations to finalize. This makes sure that we can centralize
the notion of “finalize for SILGen” and that it will be called for
everything in the source file being processed.

Author: DougGregor

lib/Sema/TypeCheckDecl.cpp

@@ -2332,8 +2332,8 @@ class DeclChecker : public DeclVisitor<DeclChecker> {
     if (auto VD = dyn_cast<ValueDecl>(decl)) {
       checkRedeclaration(TC, VD);
 
-      (void)VD->isObjC();
-      (void)VD->isDynamic();
+      // Make sure we finalize this declaration.
+      TC.DeclsToFinalize.insert(VD);
 
       // If this is a member of a nominal type, don't allow it to have a name of
       // "Type" or "Protocol" since we reserve the X.Type and X.Protocol
@@ -4683,6 +4683,17 @@ static void finalizeType(TypeChecker &TC, NominalTypeDecl *nominal) {
       continue;
 
     TC.DeclsToFinalize.insert(VD);
+
+    // The only thing left to do is synthesize storage for lazy variables.
+    auto *prop = dyn_cast<VarDecl>(D);
+    if (!prop)
+      continue;
+
+    if (prop->getAttrs().hasAttribute<LazyAttr>() && !prop->isStatic() &&
+        (!prop->getGetter() || !prop->getGetter()->hasBody())) {
+      finalizeAbstractStorageDecl(TC, prop);
+      TC.completeLazyVarImplementation(prop);
+    }
   }
 
   if (auto *CD = dyn_cast<ClassDecl>(nominal)) {
@@ -4726,19 +4737,8 @@ void TypeChecker::finalizeDecl(ValueDecl *decl) {
     finalizeType(*this, nominal);
   } else if (auto storage = dyn_cast<AbstractStorageDecl>(decl)) {
     finalizeAbstractStorageDecl(*this, storage);
-
-    // Synthesize storage for lazy variables, if still needed.
-    if (auto var = dyn_cast<VarDecl>(decl)) {
-      if (var->getAttrs().hasAttribute<LazyAttr>() && !var->isStatic() &&
-          var->getGetter() && !var->getGetter()->hasBody()) {
-        completeLazyVarImplementation(var);
-      }
-    }
   }
 
-  // Ensure that we've computed access.
-  (void)decl->getFormalAccess();
-
   // Compute overrides.
   (void)decl->getOverriddenDecls();
 

lib/Sema/TypeChecker.cpp

@@ -569,7 +569,7 @@ static void typeCheckFunctionsAndExternalDecls(SourceFile &SF, TypeChecker &TC)
     // FIXME: If we're not planning to run SILGen, this is wasted effort.
     while (TC.NextDeclToFinalize < TC.DeclsToFinalize.size()) {
       auto decl = TC.DeclsToFinalize[TC.NextDeclToFinalize++];
-      if (decl->isInvalid() || TC.Context.hadError())
+      if (decl->isInvalid())
         continue;
 
       TC.finalizeDecl(decl);

test/FixCode/fixits-apply-objc.swift

@@ -4,15 +4,6 @@ import ObjectiveC
 
 // REQUIRES: objc_interop
 
-@objc class Selectors {
-  func takeSel(_: Selector) {}
-  func mySel() {}
-  func test() {
-    takeSel("mySel")
-    takeSel(Selector("mySel"))
-  }
-}
-
 func foo(an : Any) {
   let a1 : AnyObject
   a1 = an

test/FixCode/fixits-apply-objc.swift.result

@@ -4,15 +4,6 @@ import ObjectiveC
 
 // REQUIRES: objc_interop
 
-@objc class Selectors {
-  func takeSel(_: Selector) {}
-  func mySel() {}
-  func test() {
-    takeSel(#selector(Selectors.mySel))
-    takeSel(#selector(Selectors.mySel))
-  }
-}
-
 func foo(an : Any) {
   let a1 : AnyObject
   a1 = an as AnyObject

test/IDE/complete_pound_keypath.swift

@@ -41,6 +41,5 @@ func completeInKeyPath2() {
 // CHECK-IN_KEYPATH: Decl[InstanceVar]/CurrNominal:      prop1[#String#]; name=prop1
 // CHECK-IN_KEYPATH: Decl[InstanceVar]/CurrNominal:      prop2[#ObjCClass?#]; name=prop2
 // CHECK-IN_KEYPATH: Decl[InstanceVar]/Super:            hashValue[#Int#]; name=hashValue
-// CHECK-IN_KEYPATH: Decl[InstanceVar]/Super:            hash[#Int#]; name=hash
 
 

test/Sema/Inputs/availability_multi_other.swift

@@ -32,17 +32,18 @@ class OtherIntroduced10_51 {
     return OtherIntroduced10_52()
   }
 
-  func takes10_52(o: OtherIntroduced10_52) { 
+  func takes10_52(o: OtherIntroduced10_52) {
   }
-
+  // expected-error@-2{{'OtherIntroduced10_52' is only available on OS X 10.52 or newer}}
+  // expected-note@-3{{add @available attribute to enclosing instance method}}
+  
   @available(OSX, introduced: 10.52)
   func takes10_52Introduced10_52(o: OtherIntroduced10_52) {
   }
 
+  // expected-error@+1{{'OtherIntroduced10_52' is only available on OS X 10.52 or newer}}
   var propOf10_52: OtherIntroduced10_52 = 
-
-
-      OtherIntroduced10_52() // We don't expect an error here because the initializer is not type checked (by design).
+      OtherIntroduced10_52()
 
   @available(OSX, introduced: 10.52)
   var propOf10_52Introduced10_52: OtherIntroduced10_52 = OtherIntroduced10_52()

test/Sema/Inputs/circularity_multifile_error_helper.swift

@@ -1,5 +1,5 @@
 struct External {
-  var member: Something
+  var member: Something // expected-error{{use of undeclared type 'Something'}}
 }
 
 struct OtherExternal {}

test/decl/protocol/conforms/near_miss_objc.swift

@@ -10,7 +10,7 @@
 class C1a : P1 {
   @objc func doSomething(a: Int, c: Double) { }
   // expected-warning@-1{{instance method 'doSomething(a:c:)' nearly matches optional requirement 'doSomething(a:b:)' of protocol 'P1'}}
-  // expected-note@-2{{rename to 'doSomething(a:b:)' to satisfy this requirement}}{{34-34=b }}{{none}}
+  // expected-note@-2{{rename to 'doSomething(a:b:)' to satisfy this requirement}}{{34-34=b }}{{8-8=(doSomethingWithA:b:)}} {{34-34=b }}
   // expected-note@-3{{move 'doSomething(a:c:)' to an extension to silence this warning}}
   // expected-note@-4{{make 'doSomething(a:c:)' private to silence this warning}}{{9-9=private }}
 }