Merge pull request #70831 from slavapestov/slava/fix-120743365-5.10

Sema: Fix logic error in TypeReprCycleCheckWalker handling of 'Self.Foo' [5.10]

Author: hborla

lib/Sema/TypeCheckProtocolInference.cpp

@@ -211,7 +211,8 @@ struct TypeReprCycleCheckWalker : ASTWalker {
 
       // If we're inferring `Foo`, don't look at a witness mentioning `Self.Foo`.
       if (auto *identTyR = dyn_cast<SimpleIdentTypeRepr>(baseTyR)) {
-        if (identTyR->getNameRef().getBaseIdentifier() == ctx.Id_Self) {
+        if (identTyR->getNameRef().getBaseIdentifier() == ctx.Id_Self &&
+            circularNames.count(memberTyR->getNameRef().getBaseIdentifier()) > 0) {
           // But if qualified lookup can find a type with this name without
           // looking into protocol members, don't skip the witness, since this
           // type might be a candidate witness.

test/decl/protocol/req/assoc_type_inference_cycle.swift

@@ -131,3 +131,19 @@ public struct LogTypes: OptionSet {
 
   public let rawValue: Int
 }
+
+// rdar://120743365
+public struct G<T> {}
+
+public protocol HasAlias {
+  typealias A = G<Self>
+  associatedtype B
+
+  func f1(_: Self.A, _: Self.B)
+  func f2(_: Self.A, _: Self.B)
+}
+
+public struct ConformsHasAlias: HasAlias {
+  public func f1(_: Self.A, _: Self.B) {}
+  public func f2(_: Self.A, _: Int) {}
+}