Merge pull request #27402 from xedin/missing-args-asan-atmpt-2

[ConstraintSystem] Materialize locator only once per missing argument

Author: xedin

lib/Sema/CSSimplify.cpp

@@ -837,20 +837,20 @@ class ArgumentFailureTracker : public MatchCallArgumentListener {
     const auto &param = Parameters[paramIdx];
 
     unsigned newArgIdx = Arguments.size();
-    auto argLoc =
+    auto *argLoc = CS.getConstraintLocator(
         Locator
             .withPathElement(LocatorPathElt::ApplyArgToParam(
                 newArgIdx, paramIdx, param.getParameterFlags()))
-            .withPathElement(LocatorPathElt::SynthesizedArgument(newArgIdx));
+            .withPathElement(LocatorPathElt::SynthesizedArgument(newArgIdx)));
 
-    auto *argType = CS.createTypeVariable(
-        CS.getConstraintLocator(argLoc),
-        TVO_CanBindToInOut | TVO_CanBindToLValue | TVO_CanBindToNoEscape);
+    auto *argType =
+        CS.createTypeVariable(argLoc, TVO_CanBindToInOut | TVO_CanBindToLValue |
+                                          TVO_CanBindToNoEscape);
 
     CS.recordHole(argType);
-    CS.addUnsolvedConstraint(Constraint::create(
-        CS, ConstraintKind::Defaultable, argType, CS.getASTContext().TheAnyType,
-        CS.getConstraintLocator(argLoc)));
+    CS.addUnsolvedConstraint(
+        Constraint::create(CS, ConstraintKind::Defaultable, argType,
+                           CS.getASTContext().TheAnyType, argLoc));
 
     Arguments.push_back(param.withType(argType));
     ++NumSynthesizedArgs;