Always emit id and actorSystem in expected order

Without this change, the results of the `enumerateStoredPropertiesAndMissing` function still might return in the wrong order.

Specifically, previously we would emit the stored, synthesized properties in the right order:

```
(var_decl implicit "id" type='SampleSystem.ActorID' interface type='SampleSystem.ActorID' access=public let readImpl=stored immutable
  (accessor_decl implicit 'anonname=0x1372fc578' interface type='(Worker_OTHER_MODULE) -> () -> SampleSystem.ActorID' ...

(var_decl implicit "actorSystem" type='Worker_OTHER_MODULE.ActorSystem' interface type='Worker_OTHER_MODULE.ActorSystem' access=public let readImpl=stored immutable
  (accessor_decl implicit 'anonname=0x1372fc908' interface type='(Worker_OTHER_MODULE) -> () -> Worker_OTHER_MODULE.ActorSystem' ...
```

However, the results would still be in the "normal" order if the properties were from the interface (I think because the protocol conformance?), rather than the concrete nominal... This would manifest in results looking like this:

```
(var_decl implicit "actorSystem" type='Worker_OTHER_MODULE.ActorSystem' interface type='Worker_OTHER_MODULE.ActorSystem' access=public let readImpl=stored immutable
  (accessor_decl implicit 'anonname=0x147186770' access=public final get_for=actorSystem
    (parameter "self")
    (parameter_list)))
(var_decl implicit "id" type='SampleSystem.ActorID' interface type='SampleSystem.ActorID' access=public let readImpl=stored immutable
  (accessor_decl implicit 'anonname=0x14718aa18' access=public final get_for=id
    (parameter "self")
    (parameter_list)))
```

Since those are not implicit, and just getters for the properties they would emitted in arbitrary order again. While this should not matter I guess... it definitely does, as fixing the order of this causes `irgen::forEachField` to emit them in the right order always.

I have confirmed this in a real project where the types in IRGen now align and are consistently correct:

```
-> % cat main.ir | grep Worker | grep '= type <'
%T3Lib19Worker_OTHER_MODULEC = type <{ %swift.refcounted, %swift.defaultactor, %T3Lib20THE_ACTOR_IDENTIFIERV, %T3Lib12SampleSystemC* }>

-> % cat othermodule.ir | grep Worker | grep '= type <'
%T3Lib19Worker_OTHER_MODULEC = type <{ %swift.refcounted, %swift.defaultactor, %T3Lib20THE_ACTOR_IDENTIFIERV, %T3Lib12SampleSystemC* }>
```

I am not very sure how to write a test covering this but will try to do this next as we would not want to regress this under any circumstances.

Author: ktoso

lib/Sema/TypeCheckStorage.cpp

@@ -165,12 +165,12 @@ static void enumerateStoredPropertiesAndMissing(
     ASTContext &ctx = decl->getASTContext();
     for (auto *member : decl->getMembers()) {
       if (auto *var = dyn_cast<VarDecl>(member)) {
-        if (!var->isStatic() && var->hasStorage() &&
-            var->isSynthesized()) {
-          if (var->getName() == ctx.Id_id)
+        if (!var->isStatic() && var->hasStorage()) {
+          if (var->getName() == ctx.Id_id) {
             distributedActorId = var;
-          else if (var->getName() == ctx.Id_actorSystem)
+          } else if (var->getName() == ctx.Id_actorSystem) {
             distributedActorSystem = var;
+          }
         }
 
         if (distributedActorId && distributedActorSystem)
@@ -186,9 +186,13 @@ static void enumerateStoredPropertiesAndMissing(
 
   for (auto *member : decl->getMembers()) {
     if (auto *var = dyn_cast<VarDecl>(member)) {
-      if (!var->isStatic() && var->hasStorage() &&
-          var != distributedActorId &&
-          var != distributedActorSystem) {
+      if (!var->isStatic() && var->hasStorage()) {
+        // Skip any properties that we already emitted explicitly
+        if (var == distributedActorId)
+          continue;
+        if (var == distributedActorSystem)
+          continue;
+
         addStoredProperty(var);
       }
     }