[5.1] CastOptimizer: Fix for opaque archetypes

The fallthrough path of this function assumes failure :(.

rdar://50544445

Author: aschwaighofer

lib/SIL/DynamicCasts.cpp

@@ -307,6 +307,10 @@ swift::classifyDynamicCast(ModuleDecl *M,
                            bool isWholeModuleOpts) {
   if (source == target) return DynamicCastFeasibility::WillSucceed;
 
+  // Return a conservative answer for opaque archetypes for now.
+  if (source->hasOpaqueArchetype() || target->hasOpaqueArchetype())
+    return DynamicCastFeasibility::MaySucceed;
+
   auto sourceObject = source.getOptionalObjectType();
   auto targetObject = target.getOptionalObjectType();
 

test/SILOptimizer/cast_folding.swift

@@ -1,4 +1,5 @@
 // RUN: %target-swift-frontend -O -emit-sil %s | %FileCheck %s
+// RUN: %target-swift-frontend -Onone -emit-sil %s | %FileCheck %s --check-prefix=MANDATORY
 // We want to check two things here:
 // - Correctness
 // - That certain "is" checks are eliminated based on static analysis at compile-time
@@ -1065,6 +1066,24 @@ public func testCastToPForOptionalFailure() -> Bool {
   return testCastToPForOptional(t)
 }
 
+struct Underlying : P {
+}
+
+func returnOpaque() -> some P {
+  return Underlying()
+}
+
+// MANDATORY-LABEL: sil{{.*}} @$s12cast_folding23testCastOpaqueArchetypeyyF
+// MANDATORY:   [[O:%.*]] = alloc_stack $@_opaqueReturnTypeOf("$s12cast_folding12returnOpaqueQryF", 0)
+// MANDATORY:   [[F:%.*]] = function_ref @$s12cast_folding12returnOpaqueQryF
+// MANDATORY:   apply [[F]]([[O]])
+// MANDATORY:   [[U:%.*]] = alloc_stack $Underlying
+// MANDATORY:   unconditional_checked_cast_addr @_opaqueReturnTypeOf{{.*}}in [[O]] : $*@_opaqueReturnTypeOf{{.*}}to Underlying in [[U]] : $*Underlying
+// MANDATORY:   load [[U]] : $*Underlying
+public func testCastOpaqueArchetype() {
+  let o = returnOpaque() as! Underlying
+}
+
 print("test0=\(test0())")
 
 print("test1=\(test1())")