[Tests] Fix Radar problem <rdar:/19508336>

"Extend test/SILPasses/diagnostic_constant_propagation.swift" by removing
tests from the file that referred to `Int` and `UInt` types.
These tests are dependent on the word length of the architecture and
are covered by the tests in the files
`diagnostic_constant_propagation_int_archXX.swift`.

Also, this commit corrects erroneous references to a radar problem
in the test suties: `diagnostic_constant_propagation_int_archXX.swift`

Author: ravikandhadai

test/SILOptimizer/diagnostic_constant_propagation.swift

@@ -1,7 +1,5 @@
 // RUN: %target-swift-frontend -emit-sil -primary-file %s -o /dev/null -verify
 //
-// REQUIRES: PTRSIZE=64
-//
 // These are tests for diagnostics produced by constant propagation pass.
 // Due to the change in the implementation of Integer initializers some of the
 // tests here that must fail don't currently. Such tests have comments
@@ -10,9 +8,6 @@
 // References: <rdar://problem/29937936>, <rdar://problem/29939484>,
 // <https://bugs.swift.org/browse/SR-5964>, <rdar://problem/39120081>
 
-// FIXME: <rdar://problem/19508336> Extend
-// test/SILOptimizer/diagnostic_constant_propagation.swift to 32-bit platforms
-
 func testArithmeticOverflow() {
   let xu8 : UInt8 = 250
   let yu8 : UInt8 = 250
@@ -258,12 +253,6 @@ func testDivision() {
 }
 
 func testPostIncOverflow() {
-  var   s_max = Int.max
-  s_max += 1  // expected-error {{arithmetic operation '9223372036854775807 + 1' (on type 'Int') results in an overflow}}
-
-  var   u_max = UInt.max
-  u_max += 1 // expected-error {{arithmetic operation '18446744073709551615 + 1' (on type 'UInt') results in an overflow}}
-
   var  s8_max = Int8.max
   s8_max += 1 // expected-error {{arithmetic operation '127 + 1' (on type 'Int8') results in an overflow}}
 
@@ -290,12 +279,6 @@ func testPostIncOverflow() {
 }
 
 func testPostDecOverflow() {
-  var   s_min = Int.min
-  s_min -= 1  // expected-error {{arithmetic operation '-9223372036854775808 - 1' (on type 'Int') results in an overflow}}
-
-  var   u_min = UInt.min
-  u_min -= 1 // expected-error {{arithmetic operation '0 - 1' (on type 'UInt') results in an overflow}}
-
   var  s8_min = Int8.min
   s8_min -= 1 // expected-error {{arithmetic operation '-128 - 1' (on type 'Int8') results in an overflow}}
 

test/SILOptimizer/diagnostic_constant_propagation_int_arch32.swift

@@ -11,7 +11,7 @@
 //
 // FIXME: <rdar://problem/29937936> False negatives when using integer initializers
 //
-// FIXME: <rdar://problem/19623142> A false negative that happens only in REPL
+// FIXME: <rdar://problem/39193272> A false negative that happens only in REPL
 
 func testArithmeticOverflow_Int_32bit() {
   do {
@@ -28,7 +28,7 @@ func testArithmeticOverflow_Int_32bit() {
     var _: Int = -(-0x7fff_ffff) // OK
     var _: Int = -(-0x8000_0000) // expected-error {{arithmetic operation '0 - -2147483648' (on signed 32-bit integer type) results in an overflow}}
     // FIXME: Missing diagnostic in REPL:
-    // <rdar://problem/19623142> Overflow in arithmetic negation is not detected
+    // <rdar://problem/39193272> Overflow in arithmetic negation is not detected
     // at compile time when running in REPL
   }
 

test/SILOptimizer/diagnostic_constant_propagation_int_arch64.swift

@@ -11,7 +11,7 @@
 //
 // FIXME: <rdar://problem/29937936> False negatives when using integer initializers
 //
-// FIXME: <rdar://problem/19623142> A false negative that happens only in REPL
+// FIXME: <rdar://problem/39193272> A false negative that happens only in REPL
 
 func testArithmeticOverflow_Int_64bit() {
   do {
@@ -28,7 +28,7 @@ func testArithmeticOverflow_Int_64bit() {
     var _: Int = -(-0x7fff_ffff_ffff_ffff) // OK
     var _: Int = -(-0x8000_0000_0000_0000) // expected-error {{arithmetic operation '0 - -9223372036854775808' (on signed 64-bit integer type) results in an overflow}}
     // FIXME: Missing diagnostic in REPL:
-    // <rdar://problem/19623142> Overflow in arithmetic negation is not detected
+    // <rdar://problem/39193272> Overflow in arithmetic negation is not detected
     // at compile time when running in REPL
   }