Allow a borrowed address to be passed as in_guaranteed arg in partial_apply [on_stack] only

Author: meg-gupta

lib/SIL/Verifier/LoadBorrowImmutabilityChecker.cpp

@@ -245,7 +245,8 @@ bool GatherWritesVisitor::visitUse(Operand *op, AccessUseType useTy) {
 
   if (auto *pa = dyn_cast<PartialApplyInst>(user)) {
     auto argConv = ApplySite(user).getArgumentConvention(*op);
-    if (argConv == SILArgumentConvention::Indirect_In_Guaranteed) {
+    if (pa->isOnStack() &&
+        argConv == SILArgumentConvention::Indirect_In_Guaranteed) {
       return true;
     }
 

test/SIL/ownership-verifier/load_borrow_invalidation_partial_apply.sil

@@ -1,4 +1,5 @@
-// RUN: %target-sil-opt -enable-sil-verify-all -inline %s -o /dev/null
+// RUN: %target-sil-opt -enable-sil-verify-all -inline %s -verify-continue-on-failure=true -o /dev/null 2>&1 | %FileCheck %s
+// REQUIRES: asserts
 
 // Tests here are patterns we should not consider as broken
 
@@ -37,6 +38,7 @@ bb0(%0 :  $*WrapperStruct):
   return %res : $()
 }
 
+// CHECK-NOT: Function: 'caller1'
 sil [ossa] @caller1 : $@convention(thin) (@owned WrapperStruct) -> () {
 bb0(%0 :  @owned $WrapperStruct):
   %stk = alloc_stack $WrapperStruct
@@ -49,6 +51,9 @@ bb0(%0 :  @owned $WrapperStruct):
   return %res : $()
 }
 
+// CHECK-LABEL: Begin Error in function caller2
+// CHECK: SIL verification failed: Found load borrow that is invalidated by a local write?!: loadBorrowImmutabilityAnalysis.isImmutable(LBI)
+// CHECK-LABEL: End Error in function caller2
 sil [ossa] @caller2 : $@convention(thin) (@owned WrapperStruct) -> () {
 bb0(%0 :  @owned $WrapperStruct):
   %stk = alloc_stack $WrapperStruct