Merge pull request #9572 from practicalswift/gardening-20170513

[gardening] Remove assert requirement from fixed crashers. Fix spacing. Remove unused variables.

Author: practicalswift

lib/IDE/APIDigesterData.cpp

@@ -117,7 +117,7 @@ TypeMemberDiffItemSubKind
 swift::ide::api::TypeMemberDiffItem::getSubKind() const {
   DeclNameViewer OldName = getOldName();
   DeclNameViewer NewName = getNewName();
-  if(!OldName.isFunction()) {
+  if (!OldName.isFunction()) {
     assert(!NewName.isFunction());
     return TypeMemberDiffItemSubKind::SimpleReplacement;
   }

lib/IRGen/LoadableByAddress.cpp

@@ -107,8 +107,7 @@ static bool containsLargeLoadable(GenericEnvironment *GenericEnv,
                                 currSILFunctionType->getParameters(), Mod)) {
         return true;
       }
-    } else if (auto *currSILBlockType =
-                   dyn_cast<SILBlockStorageType>(currCanType.getPointer())) {
+    } else if (isa<SILBlockStorageType>(currCanType.getPointer())) {
       continue;
     } else {
       switch (param.getConvention()) {
@@ -303,8 +302,7 @@ static SILType getNewSILType(GenericEnvironment *GenericEnv,
     return newSILType;
   }
   CanType currCanType = storageType.getSwiftRValueType();
-  if (auto *currSILBlockType =
-          dyn_cast<SILBlockStorageType>(currCanType.getPointer())) {
+  if (isa<SILBlockStorageType>(currCanType.getPointer())) {
     return storageType;
   }
   if (SILFunctionType *currSILFunctionType =
@@ -693,14 +691,14 @@ void LargeValueVisitor::visitTupleInst(SILInstruction *instr) {
 
 void LargeValueVisitor::visitAllocStackInst(AllocStackInst *instr) {
   SILType currSILType = instr->getType().getObjectType();
-  if (auto *fType = getInnerFunctionType(currSILType)) {
+  if (getInnerFunctionType(currSILType)) {
     pass.allocStackInstsToMod.push_back(instr);
   }
 }
 
 void LargeValueVisitor::visitPointerToAddressInst(PointerToAddressInst *instr) {
   SILType currSILType = instr->getType().getObjectType();
-  if (auto *fType = getInnerFunctionType(currSILType)) {
+  if (getInnerFunctionType(currSILType)) {
     pass.pointerToAddrkInstsToMod.push_back(instr);
   }
 }

lib/SILOptimizer/IPO/DeadFunctionElimination.cpp

@@ -210,8 +210,7 @@ class FunctionLivenessComputation {
             ensureAliveClassMethod(getMethodInfo(decl, /*witness*/ false),
                                    dyn_cast<FuncDecl>(decl),
                                    clas);
-          } else if (auto proto =
-                       dyn_cast<ProtocolDecl>(decl->getDeclContext())) {
+          } else if (isa<ProtocolDecl>(decl->getDeclContext())) {
             ensureAliveProtocolMethod(getMethodInfo(decl, /*witness*/ true));
           } else {
             llvm_unreachable("key path keyed by a non-class, non-protocol method");

validation-test/IDE/crashers_2_fixed/0012-protocol-where-clause.swift

@@ -1,4 +1,3 @@
 // RUN: %target-swift-ide-test -code-completion -code-completion-token=A -source-filename=%s
-// REQUIRES: asserts
 
 protocol a where #^A^#

validation-test/compiler_crashers_fixed/28614-args-size-fnref-getnumargumentsforfullapply-partial-application-was-throwing.swift

@@ -6,5 +6,4 @@
 // See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
 
 // RUN: not %target-swift-frontend %s -emit-ir
-// REQUIRES: asserts
 func a{guard let[]=(a||()A