Skip to content

Commit 714ff04

Browse files
authored
Merge pull request #69605 from apple/egorzhdan/5.10-cxx-lower-deployment-target
🍒[cxx-interop] Lower macOS deployment target version for the Cxx module
2 parents 333938d + 31943e1 commit 714ff04

File tree

4 files changed

+32
-3
lines changed

4 files changed

+32
-3
lines changed

stdlib/cmake/modules/AddSwiftStdlib.cmake

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -978,6 +978,10 @@ function(add_swift_target_library_single target name)
978978
${SWIFTLIB_SINGLE_NO_LINK_NAME_keyword}
979979
ENABLE_LTO "${SWIFTLIB_SINGLE_ENABLE_LTO}"
980980
INSTALL_IN_COMPONENT "${install_in_component}"
981+
DEPLOYMENT_VERSION_OSX ${SWIFTLIB_SINGLE_DEPLOYMENT_VERSION_OSX}
982+
DEPLOYMENT_VERSION_IOS ${SWIFTLIB_SINGLE_DEPLOYMENT_VERSION_IOS}
983+
DEPLOYMENT_VERSION_TVOS ${SWIFTLIB_SINGLE_DEPLOYMENT_VERSION_TVOS}
984+
DEPLOYMENT_VERSION_WATCHOS ${SWIFTLIB_SINGLE_DEPLOYMENT_VERSION_WATCHOS}
981985
MACCATALYST_BUILD_FLAVOR "${SWIFTLIB_SINGLE_MACCATALYST_BUILD_FLAVOR}"
982986
${BOOTSTRAPPING_arg})
983987
add_swift_source_group("${SWIFTLIB_SINGLE_EXTERNAL_SOURCES}")

stdlib/cmake/modules/SwiftSource.cmake

Lines changed: 24 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ function(handle_swift_sources
5050
sourcesvar externalvar name)
5151
cmake_parse_arguments(SWIFTSOURCES
5252
"IS_MAIN;IS_STDLIB;IS_STDLIB_CORE;IS_SDK_OVERLAY;EMBED_BITCODE;STATIC;NO_LINK_NAME;IS_FRAGILE"
53-
"SDK;ARCHITECTURE;INSTALL_IN_COMPONENT;MACCATALYST_BUILD_FLAVOR;BOOTSTRAPPING"
53+
"SDK;ARCHITECTURE;INSTALL_IN_COMPONENT;DEPLOYMENT_VERSION_OSX;DEPLOYMENT_VERSION_IOS;DEPLOYMENT_VERSION_TVOS;DEPLOYMENT_VERSION_WATCHOS;MACCATALYST_BUILD_FLAVOR;BOOTSTRAPPING"
5454
"DEPENDS;COMPILE_FLAGS;MODULE_NAME;ENABLE_LTO"
5555
${ARGN})
5656
translate_flag(${SWIFTSOURCES_IS_MAIN} "IS_MAIN" IS_MAIN_arg)
@@ -155,6 +155,10 @@ function(handle_swift_sources
155155
${BOOTSTRAPPING_arg}
156156
${IS_FRAGILE_arg}
157157
INSTALL_IN_COMPONENT "${SWIFTSOURCES_INSTALL_IN_COMPONENT}"
158+
DEPLOYMENT_VERSION_OSX ${SWIFTSOURCES_DEPLOYMENT_VERSION_OSX}
159+
DEPLOYMENT_VERSION_IOS ${SWIFTSOURCES_DEPLOYMENT_VERSION_IOS}
160+
DEPLOYMENT_VERSION_TVOS ${SWIFTSOURCES_DEPLOYMENT_VERSION_TVOS}
161+
DEPLOYMENT_VERSION_WATCHOS ${SWIFTSOURCES_DEPLOYMENT_VERSION_WATCHOS}
158162
MACCATALYST_BUILD_FLAVOR "${SWIFTSOURCES_MACCATALYST_BUILD_FLAVOR}")
159163
set("${dependency_target_out_var_name}" "${dependency_target}" PARENT_SCOPE)
160164
set("${dependency_module_target_out_var_name}" "${module_dependency_target}" PARENT_SCOPE)
@@ -222,7 +226,7 @@ function(_add_target_variant_swift_compile_flags
222226
cmake_parse_arguments(
223227
VARIANT # prefix
224228
"" # options
225-
"MACCATALYST_BUILD_FLAVOR" # single-value args
229+
"MACCATALYST_BUILD_FLAVOR;DEPLOYMENT_VERSION_OSX;DEPLOYMENT_VERSION_IOS;DEPLOYMENT_VERSION_TVOS;DEPLOYMENT_VERSION_WATCHOS" # single-value args
226230
"" # multi-value args
227231
${ARGN})
228232

@@ -233,6 +237,19 @@ function(_add_target_variant_swift_compile_flags
233237

234238
if("${sdk}" IN_LIST SWIFT_DARWIN_PLATFORMS)
235239
set(sdk_deployment_version "${SWIFT_SDK_${sdk}_DEPLOYMENT_VERSION}")
240+
if("${sdk}" STREQUAL "OSX" AND DEFINED VARIANT_DEPLOYMENT_VERSION_OSX)
241+
set(sdk_deployment_version ${VARIANT_DEPLOYMENT_VERSION_OSX})
242+
endif()
243+
if("${sdk}" STREQUAL "IOS" AND DEFINED VARIANT_DEPLOYMENT_VERSION_IOS)
244+
set(sdk_deployment_version ${VARIANT_DEPLOYMENT_VERSION_IOS})
245+
endif()
246+
if("${sdk}" STREQUAL "TVOS" AND DEFINED VARIANT_DEPLOYMENT_VERSION_TVOS)
247+
set(sdk_deployment_version ${VARIANT_DEPLOYMENT_VERSION_TVOS})
248+
endif()
249+
if("${sdk}" STREQUAL "WATCHOS" AND DEFINED VARIANT_DEPLOYMENT_VERSION_WATCHOS)
250+
set(sdk_deployment_version ${VARIANT_DEPLOYMENT_VERSION_WATCHOS})
251+
endif()
252+
236253
get_target_triple(target target_variant "${sdk}" "${arch}"
237254
MACCATALYST_BUILD_FLAVOR "${VARIANT_MACCATALYST_BUILD_FLAVOR}"
238255
DEPLOYMENT_VERSION "${sdk_deployment_version}")
@@ -379,7 +396,7 @@ function(_compile_swift_files
379396
dependency_sibgen_target_out_var_name)
380397
cmake_parse_arguments(SWIFTFILE
381398
"IS_MAIN;IS_STDLIB;IS_STDLIB_CORE;IS_SDK_OVERLAY;EMBED_BITCODE;STATIC;IS_FRAGILE"
382-
"OUTPUT;MODULE_NAME;INSTALL_IN_COMPONENT;MACCATALYST_BUILD_FLAVOR;BOOTSTRAPPING"
399+
"OUTPUT;MODULE_NAME;INSTALL_IN_COMPONENT;DEPLOYMENT_VERSION_OSX;DEPLOYMENT_VERSION_IOS;DEPLOYMENT_VERSION_TVOS;DEPLOYMENT_VERSION_WATCHOS;MACCATALYST_BUILD_FLAVOR;BOOTSTRAPPING"
383400
"SOURCES;FLAGS;DEPENDS;SDK;ARCHITECTURE;OPT_FLAGS;MODULE_DIR"
384401
${ARGN})
385402

@@ -452,6 +469,10 @@ function(_compile_swift_files
452469
"${SWIFT_STDLIB_BUILD_TYPE}"
453470
"${SWIFT_STDLIB_ASSERTIONS}"
454471
swift_flags
472+
DEPLOYMENT_VERSION_OSX ${SWIFTFILE_DEPLOYMENT_VERSION_OSX}
473+
DEPLOYMENT_VERSION_IOS ${SWIFTFILE_DEPLOYMENT_VERSION_IOS}
474+
DEPLOYMENT_VERSION_TVOS ${SWIFTFILE_DEPLOYMENT_VERSION_TVOS}
475+
DEPLOYMENT_VERSION_WATCHOS ${SWIFTFILE_DEPLOYMENT_VERSION_WATCHOS}
455476
MACCATALYST_BUILD_FLAVOR "${maccatalyst_build_flavor}"
456477
)
457478

stdlib/public/Cxx/CMakeLists.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@ add_swift_target_library(swiftCxx STATIC NO_LINK_NAME IS_STDLIB IS_SWIFT_ONLY IS
2323
# For functionality that depends on the C++ stdlib, use C++ stdlib overlay (`swiftstd` module).
2424
-Xcc -nostdinc++
2525

26+
DEPLOYMENT_VERSION_OSX ${COMPATIBILITY_MINIMUM_DEPLOYMENT_VERSION_OSX}
27+
2628
LINK_FLAGS "${SWIFT_RUNTIME_SWIFT_LINK_FLAGS}"
2729
DEPENDS ${SWIFT_CXX_DEPS}
2830
INSTALL_IN_COMPONENT compiler

stdlib/public/Cxx/std/CMakeLists.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,8 @@ add_swift_target_library(swiftCxxStdlib STATIC NO_LINK_NAME IS_STDLIB IS_SWIFT_O
4949
SWIFT_COMPILE_FLAGS_LINUX
5050
${SWIFT_SDK_LINUX_CXX_OVERLAY_SWIFT_COMPILE_FLAGS}
5151

52+
DEPLOYMENT_VERSION_OSX ${COMPATIBILITY_MINIMUM_DEPLOYMENT_VERSION_OSX}
53+
5254
LINK_FLAGS "${SWIFT_RUNTIME_SWIFT_LINK_FLAGS}"
5355
TARGET_SDKS ALL_APPLE_PLATFORMS LINUX WINDOWS
5456
INSTALL_IN_COMPONENT compiler

0 commit comments

Comments
 (0)