Skip to content

Commit 71a77cd

Browse files
committed
[cxx-interop] Remove -fno-rtti workaround in tests
`-Xcc -fno-rtti` flags were added to these tests back in 2020 when we could not properly link with the C++ stdlib. This should hopefully speed up these tests, which are currently among the slowest tests in the project.
1 parent 1832268 commit 71a77cd

File tree

2 files changed

+3
-11
lines changed

2 files changed

+3
-11
lines changed

test/Interop/Cxx/value-witness-table/custom-destructors-virtual-irgen.swift

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,4 @@
1-
// With RTTI some of the objects with virtual bases / destructors in this test
2-
// will cause linker errors because of undefined vtables.
3-
// FIXME: Once we can link with libc++ we can start using RTTI.
4-
//
5-
// RUN: %target-swift-frontend -enable-experimental-cxx-interop -I %S/Inputs %s -emit-ir -Xcc -fno-rtti | %FileCheck %s
1+
// RUN: %target-swift-frontend -enable-experimental-cxx-interop -I %S/Inputs %s -emit-ir | %FileCheck %s
62

73
import CustomDestructor
84

test/Interop/Cxx/value-witness-table/custom-destructors-virtual.swift

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
1-
// With RTTI some of the objects with virtual bases / destructors in this test
2-
// will cause linker errors because of undefined vtables.
3-
// FIXME: Once we can link with libc++ we can start using RTTI.
4-
//
5-
// RUN: %target-run-simple-swift(-I %S/Inputs -Xfrontend -enable-experimental-cxx-interop -Xcc -fno-rtti)
6-
// RUN: %target-run-simple-swift(-I %S/Inputs -Xfrontend -enable-experimental-cxx-interop -Xcc -fno-rtti -O)
1+
// RUN: %target-run-simple-swift(-I %S/Inputs -Xfrontend -enable-experimental-cxx-interop)
2+
// RUN: %target-run-simple-swift(-I %S/Inputs -Xfrontend -enable-experimental-cxx-interop -O)
73
//
84
// REQUIRES: executable_test
95

0 commit comments

Comments
 (0)