Parse: Remove some dead code

Author: slavapestov

include/swift/Parse/Parser.h

@@ -869,7 +869,7 @@ class Parser {
   /// Return true if parser is at the start of a decl or decl-import.
   bool isStartOfDecl();
 
-  bool parseTopLevel();
+  void parseTopLevel();
 
   /// Flags that control the parsing of declarations.
   enum ParseDeclFlags {

include/swift/Subsystems.h

@@ -119,18 +119,14 @@ namespace swift {
   ///
   /// \param PersistentState if non-null the same PersistentState object can
   /// be used to resume parsing or parse delayed function bodies.
-  ///
-  /// \return true if the parser found code with side effects.
-  bool parseIntoSourceFile(SourceFile &SF, unsigned BufferID, bool *Done,
+  void parseIntoSourceFile(SourceFile &SF, unsigned BufferID, bool *Done,
                            SILParserState *SIL = nullptr,
                            PersistentParserState *PersistentState = nullptr,
                            bool DelayBodyParsing = true);
 
   /// Parse a single buffer into the given source file, until the full source
   /// contents are parsed.
-  ///
-  /// \return true if the parser found code with side effects.
-  bool parseIntoSourceFileFull(SourceFile &SF, unsigned BufferID,
+  void parseIntoSourceFileFull(SourceFile &SF, unsigned BufferID,
                                PersistentParserState *PersistentState = nullptr,
                                bool DelayBodyParsing = true);
 

lib/Immediate/REPL.cpp

@@ -187,12 +187,10 @@ typeCheckREPLInput(ModuleDecl *MostRecentModule, StringRef Name,
     REPLInputFile.addImports(ImportsWithOptions);
   }
 
-  bool FoundAnySideEffects = false;
   bool Done;
   do {
-    FoundAnySideEffects |=
-        parseIntoSourceFile(REPLInputFile, BufferID, &Done, nullptr,
-                            &PersistentState);
+    parseIntoSourceFile(REPLInputFile, BufferID, &Done, nullptr,
+                        &PersistentState);
   } while (!Done);
   performTypeChecking(REPLInputFile);
   return REPLModule;

lib/Parse/ParseDecl.cpp

@@ -189,7 +189,7 @@ namespace {
 ///     decl-sil       [[only in SIL mode]
 ///     decl-sil-stage [[only in SIL mode]
 /// \endverbatim
-bool Parser::parseTopLevel() {
+void Parser::parseTopLevel() {
   SF.ASTStage = SourceFile::Parsing;
 
   // Prime the lexer.
@@ -246,17 +246,6 @@ bool Parser::parseTopLevel() {
     consumeToken();
   }
 
-  // If this is a Main source file, determine if we found code that needs to be
-  // executed (this is used by the repl to know whether to compile and run the
-  // newly parsed stuff).
-  bool FoundTopLevelCodeToExecute = false;
-  if (allowTopLevelCode()) {
-    for (auto V : Items) {
-      if (isa<TopLevelCodeDecl>(V.get<Decl*>()))
-        FoundTopLevelCodeToExecute = true;
-    }
-  }
-
   // Add newly parsed decls to the module.
   for (auto Item : Items) {
     if (auto *D = Item.dyn_cast<Decl*>()) {
@@ -279,8 +268,6 @@ bool Parser::parseTopLevel() {
     SyntaxContext->addToken(Tok, LeadingTrivia, TrailingTrivia);
     TokReceiver->finalize();
   }
-
-  return FoundTopLevelCodeToExecute;
 }
 
 ParserResult<AvailableAttr> Parser::parseExtendedAvailabilitySpecList(

lib/ParseSIL/ParseSIL.cpp

@@ -112,13 +112,13 @@ void PrettyStackTraceParser::print(llvm::raw_ostream &out) const {
   out << '\n';
 }
 
-static bool parseIntoSourceFileImpl(SourceFile &SF,
-                                unsigned BufferID,
-                                bool *Done,
-                                SILParserState *SIL,
-                                PersistentParserState *PersistentState,
-                                bool FullParse,
-                                bool DelayBodyParsing) {
+static void parseIntoSourceFileImpl(SourceFile &SF,
+                                    unsigned BufferID,
+                                    bool *Done,
+                                    SILParserState *SIL,
+                                    PersistentParserState *PersistentState,
+                                    bool FullParse,
+                                    bool DelayBodyParsing) {
   assert((!FullParse || (SF.canBeParsedInFull() && !SIL)) &&
          "cannot parse in full with the given parameters!");
 
@@ -149,40 +149,36 @@ static bool parseIntoSourceFileImpl(SourceFile &SF,
   llvm::SaveAndRestore<bool> S(P.IsParsingInterfaceTokens,
                                SF.hasInterfaceHash());
 
-  bool FoundSideEffects = false;
   do {
-    bool hasSideEffects = P.parseTopLevel();
-    FoundSideEffects = FoundSideEffects || hasSideEffects;
+    P.parseTopLevel();
     *Done = P.Tok.is(tok::eof);
   } while (FullParse && !*Done);
 
   if (STreeCreator) {
     auto rawNode = P.finalizeSyntaxTree();
     STreeCreator->acceptSyntaxRoot(rawNode, SF);
   }
-
-  return FoundSideEffects;
 }
 
-bool swift::parseIntoSourceFile(SourceFile &SF,
+void swift::parseIntoSourceFile(SourceFile &SF,
                                 unsigned BufferID,
                                 bool *Done,
                                 SILParserState *SIL,
                                 PersistentParserState *PersistentState,
                                 bool DelayBodyParsing) {
-  return parseIntoSourceFileImpl(SF, BufferID, Done, SIL,
-                                 PersistentState,
-                                 /*FullParse=*/SF.shouldBuildSyntaxTree(),
-                                 DelayBodyParsing);
+  parseIntoSourceFileImpl(SF, BufferID, Done, SIL,
+                          PersistentState,
+                          /*FullParse=*/SF.shouldBuildSyntaxTree(),
+                          DelayBodyParsing);
 }
 
-bool swift::parseIntoSourceFileFull(SourceFile &SF, unsigned BufferID,
+void swift::parseIntoSourceFileFull(SourceFile &SF, unsigned BufferID,
                                     PersistentParserState *PersistentState,
                                     bool DelayBodyParsing) {
   bool Done = false;
-  return parseIntoSourceFileImpl(SF, BufferID, &Done, /*SIL=*/nullptr,
-                                 PersistentState, /*FullParse=*/true,
-                                 DelayBodyParsing);
+  parseIntoSourceFileImpl(SF, BufferID, &Done, /*SIL=*/nullptr,
+                          PersistentState, /*FullParse=*/true,
+                          DelayBodyParsing);
 }