Merge pull request #36353 from apple/QuietMisdreavus/proper-path-handling

[Frontend] don't pop the last path component from -emit-symbol-graph-dir

Author: QuietMisdreavus

lib/Frontend/Frontend.cpp

@@ -164,7 +164,6 @@ SerializationOptions CompilerInvocation::computeSerializationOptions(
     }
     SmallString<256> OutputDir(serializationOpts.SymbolGraphOutputDir);
     llvm::sys::fs::make_absolute(OutputDir);
-    llvm::sys::path::remove_filename(OutputDir);
     serializationOpts.SymbolGraphOutputDir = OutputDir.str().str();
   }
 

test/SymbolGraph/EmitWhileBuilding.swift

@@ -2,6 +2,12 @@
 // RUN: %target-build-swift %s -module-name EmitWhileBuilding -emit-module -emit-module-path %t/ -emit-symbol-graph -emit-symbol-graph-dir %t/
 // RUN: %FileCheck %s --input-file %t/EmitWhileBuilding.symbols.json
 
+// also try without the trailing slash on `-emit-symbol-graph-dir` and make sure it works
+
+// RUN: %empty-directory(%t)
+// RUN: %target-build-swift %s -module-name EmitWhileBuilding -emit-module -emit-module-path %t/ -emit-symbol-graph -emit-symbol-graph-dir %t
+// RUN: %FileCheck %s --input-file %t/EmitWhileBuilding.symbols.json
+
 /// Does a foo.
 public func foo() {}