[IRGen] Report error in reading legacy layouts non-fatally. (#35498)

airspeedswift · DougGregor · web-flow · commit 73b291b6e6cf · 2021-01-21T10:00:51.000-08:00
Taking down the compiler for this is wholly unnecessary.
Part of rdar://71439646.

Co-authored-by: Doug Gregor &lt;dgregor@apple.com&gt;
diff --git a/lib/IRGen/GenType.cpp b/lib/IRGen/GenType.cpp
@@ -1420,8 +1420,9 @@ TypeConverter::TypeConverter(IRGenModule &IGM)
   }
 
   bool error = readLegacyTypeInfo(*fs, path);
-  if (error)
-    llvm::report_fatal_error("Cannot read '" + path + "'");
+  if (error) {
+    IGM.error(SourceLoc(), "Cannot read legacy layout file at '" + path + "'");
+  }
 }
 
 TypeConverter::~TypeConverter() {

Original file line number	Diff line number	Diff line change
`@@ -1420,8 +1420,9 @@ TypeConverter::TypeConverter(IRGenModule &IGM)`
`1420`	`1420`	`}`
`1421`	`1421`
`1422`	`1422`	`bool error = readLegacyTypeInfo(*fs, path);`
`1423`		`- if (error)`
`1424`		`- llvm::report_fatal_error("Cannot read '" + path + "'");`
	`1423`	`+ if (error) {`
	`1424`	`+ IGM.error(SourceLoc(), "Cannot read legacy layout file at '" + path + "'");`
	`1425`	`+ }`
`1425`	`1426`	`}`
`1426`	`1427`
`1427`	`1428`	`TypeConverter::~TypeConverter() {`