more debugging the missing deinit runs

Author: ktoso

lib/IRGen/GenDistributed.cpp

@@ -479,6 +479,7 @@ void DistributedAccessor::decodeArgument(unsigned argumentIdx,
   }
 
   case ParameterConvention::Indirect_In_Guaranteed: {
+    fprintf(stderr, "[%s:%d](%s) Indirect_In_Guaranteed\n", __FILE_NAME__, __LINE__, __FUNCTION__);
     // The argument is +0, so we can use the address of the param in
     // the context directly.
     arguments.add(resultAddr);
@@ -494,8 +495,12 @@ void DistributedAccessor::decodeArgument(unsigned argumentIdx,
   case ParameterConvention::Pack_Inout:
     llvm_unreachable("pack parameters are not supported");
 
-  case ParameterConvention::Direct_Guaranteed:
+  case ParameterConvention::Direct_Guaranteed: {
+    fprintf(stderr, "[%s:%d](%s) Direct_Guaranteed\n", __FILE_NAME__, __LINE__, __FUNCTION__);
+    LLVM_FALLTHROUGH;
+  }
   case ParameterConvention::Direct_Unowned: {
+    fprintf(stderr, "[%s:%d](%s) UNOWNED\n", __FILE_NAME__, __LINE__, __FUNCTION__);
     auto paramTy = param.getSILStorageInterfaceType();
     Address eltPtr = IGF.Builder.CreateElementBitCast(
         resultValue.getAddress(), IGM.getStorageType(paramTy));
@@ -506,6 +511,7 @@ void DistributedAccessor::decodeArgument(unsigned argumentIdx,
   }
 
   case ParameterConvention::Direct_Owned: {
+    fprintf(stderr, "[%s:%d](%s) DIRECT OWNED\n", __FILE_NAME__, __LINE__, __FUNCTION__);
     // Copy the value out at +1.
     cast<LoadableTypeInfo>(paramInfo).loadAsCopy(IGF, resultValue.getAddress(),
                                                  arguments);
@@ -593,6 +599,7 @@ void DistributedAccessor::emitReturn(llvm::Value *errorValue) {
   // Destroy loaded arguments.
   for (auto argInfo = LoadedArguments.rbegin();
        argInfo != LoadedArguments.rend(); ++argInfo) {
+
     emitDestroyCall(IGF, argInfo->second, argInfo->first);
   }
 

test/Distributed/Runtime/distributed_actor_func_calls_decoded_args_deinit.swift

@@ -1,6 +1,6 @@
 // RUN: %empty-directory(%t)
 // RUN: %target-swift-frontend-emit-module -emit-module-path %t/FakeDistributedActorSystems.swiftmodule -module-name FakeDistributedActorSystems -disable-availability-checking %S/../Inputs/FakeDistributedActorSystems.swift
-// RUN: %target-build-swift -module-name main  -Xfrontend -disable-availability-checking -j2 -parse-as-library -I %t %s %S/../Inputs/FakeDistributedActorSystems.swift -o %t/a.out
+// RUN: %target-build-swift -module-name main -O -Xfrontend -disable-availability-checking -j2 -parse-as-library -I %t %s %S/../Inputs/FakeDistributedActorSystems.swift -o %t/a.out
 // RUN: %target-codesign %t/a.out
 // RUN: %target-run %t/a.out | %FileCheck %s --color --dump-input=always
 
@@ -38,8 +38,10 @@ struct S<T> : Codable {
 }
 
 distributed actor Greeter {
-  distributed func test1<T>(_: SomeClass<T>) {}
-  distributed func test2<T>(_: S<T>) {}
+  distributed func test1<T>(_ value: SomeClass<T>) {
+    print("RETAIN COUNT IN [TEST1]: \(_swift_retainCount(value))")
+  }
+  distributed func test2<T>(_ value: S<T>) {}
 }
 
 func test() async throws {
@@ -52,7 +54,7 @@ func test() async throws {
   var value = SomeClass<Int>()
   try await ref.test1(value)
   print("RETAIN COUNT: \(_swift_retainCount(value))")
-  _swift_release(value) // FIXME: we're missing a release!
+//  _swift_release(value) // FIXME: we're missing a release!
   print("RETAIN COUNT: \(_swift_retainCount(value))")
   // CHECK: SomeClass: init
   // CHECK: SomeClass: deinit