run the move-checker if lexical lifetimes are enabled

this pulls just the move checking passes out from
behind the experimental flag.

Author: kavon

include/swift/AST/ASTContext.h

@@ -695,6 +695,9 @@ class ASTContext final {
   FuncDecl *getMakeInvocationEncoderOnDistributedActorSystem(
       AbstractFunctionDecl *thunk) const;
 
+  /// Indicates whether move-only / noncopyable types are supported.
+  bool supportsMoveOnlyTypes() const;
+
   // Retrieve the declaration of
   // DistributedInvocationEncoder.recordGenericSubstitution(_:).
   //

lib/AST/ASTContext.cpp

@@ -6352,3 +6352,8 @@ ASTContext::lookupExecutablePluginByModuleName(Identifier moduleName) {
 
   return plugin.get();
 }
+
+bool ASTContext::supportsMoveOnlyTypes() const {
+  // currently the only thing holding back whether the types can appear is this.
+  return SILOpts.LexicalLifetimes == LexicalLifetimesOption::On;
+}

lib/SILOptimizer/Mandatory/ConsumeOperatorCopyableAddressesChecker.cpp

@@ -2400,7 +2400,7 @@ class ConsumeOperatorCopyableAddressesCheckerPass
     auto &astContext = fn->getASTContext();
 
     // Only run this pass if the move only language feature is enabled.
-    if (!astContext.LangOpts.Features.contains(Feature::MoveOnly))
+    if (!astContext.supportsMoveOnlyTypes())
       return;
 
     // Don't rerun diagnostics on deserialized functions.

lib/SILOptimizer/Mandatory/ConsumeOperatorCopyableValuesChecker.cpp

@@ -527,7 +527,7 @@ class ConsumeOperatorCopyableValuesCheckerPass : public SILFunctionTransform {
     auto *fn = getFunction();
 
     // Only run this pass if the move only language feature is enabled.
-    if (!fn->getASTContext().LangOpts.Features.contains(Feature::MoveOnly))
+    if (!fn->getASTContext().supportsMoveOnlyTypes())
       return;
 
     // Don't rerun diagnostics on deserialized functions.

lib/SILOptimizer/Mandatory/MoveOnlyAddressCheckerTester.cpp

@@ -79,7 +79,7 @@ class MoveOnlyAddressCheckerTesterPass : public SILFunctionTransform {
     auto *fn = getFunction();
 
     // Only run this pass if the move only language feature is enabled.
-    if (!fn->getASTContext().LangOpts.Features.contains(Feature::MoveOnly))
+    if (!fn->getASTContext().supportsMoveOnlyTypes())
       return;
 
     // Don't rerun diagnostics on deserialized functions.

lib/SILOptimizer/Mandatory/MoveOnlyBorrowToDestructureTester.cpp

@@ -72,7 +72,7 @@ class MoveOnlyBorrowToDestructureTransformPass : public SILFunctionTransform {
     auto *fn = getFunction();
 
     // Only run this pass if the move only language feature is enabled.
-    if (!fn->getASTContext().LangOpts.Features.contains(Feature::MoveOnly))
+    if (!fn->getASTContext().supportsMoveOnlyTypes())
       return;
 
     // Don't rerun diagnostics on deserialized functions.

lib/SILOptimizer/Mandatory/MoveOnlyChecker.cpp

@@ -147,7 +147,7 @@ class MoveOnlyCheckerPass : public SILFunctionTransform {
     auto *fn = getFunction();
 
     // Only run this pass if the move only language feature is enabled.
-    if (!fn->getASTContext().LangOpts.Features.contains(Feature::MoveOnly))
+    if (!fn->getASTContext().supportsMoveOnlyTypes())
       return;
 
     // Don't rerun diagnostics on deserialized functions.

lib/SILOptimizer/Mandatory/MoveOnlyObjectCheckerTester.cpp

@@ -76,7 +76,7 @@ class MoveOnlyObjectCheckerTesterPass : public SILFunctionTransform {
     auto *fn = getFunction();
 
     // Only run this pass if the move only language feature is enabled.
-    if (!fn->getASTContext().LangOpts.Features.contains(Feature::MoveOnly))
+    if (!fn->getASTContext().supportsMoveOnlyTypes())
       return;
 
     // Don't rerun diagnostics on deserialized functions.