Skip to content

Commit 763beff

Browse files
committed
AST: Basically revert "Rename TypeTransform::transformSubMap()"
This undoes the effect of commit 865c040 since it introduced a performance regression.
1 parent ce9d5f5 commit 763beff

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

lib/AST/TypeSubstitution.cpp

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -329,7 +329,7 @@ class TypeSubstituter : public TypeTransform<TypeSubstituter> {
329329
std::optional<Type> transformLocalArchetypeType(LocalArchetypeType *local,
330330
TypePosition pos);
331331

332-
SubstitutionMap transformSubstitutionMap(SubstitutionMap subs);
332+
// SubstitutionMap transformSubstitutionMap(SubstitutionMap subs);
333333

334334
CanType transformSILField(CanType fieldTy, TypePosition pos);
335335
};
@@ -446,10 +446,13 @@ Type TypeSubstituter::transformDependentMemberType(DependentMemberType *dependen
446446
return conformance.getTypeWitness(substBase, assocType, IFS.getOptions());
447447
}
448448

449+
// FIXME: This exposes a scalability issue; see test/SILGen/opaque_result_type_slow.swift.
450+
/*
449451
SubstitutionMap TypeSubstituter::transformSubstitutionMap(SubstitutionMap subs) {
450452
// FIXME: Take level into account? Move level down into IFS?
451453
return subs.subst(IFS);
452454
}
455+
*/
453456

454457
CanType TypeSubstituter::transformSILField(CanType fieldTy, TypePosition pos) {
455458
// Type substitution does not walk into the SILBoxType's field types, because

0 commit comments

Comments
 (0)