Merge pull request #60906 from apple/QuietMisdreavus/objc-synthesis

give inherited/synthesized objc symbols a synthesized base type

Author: QuietMisdreavus

lib/SymbolGraphGen/SymbolGraphASTWalker.cpp

@@ -237,6 +237,19 @@ bool SymbolGraphASTWalker::walkToDeclPre(Decl *D, CharSourceRange Range) {
     }
   }
 
+  // Clang decls that are inherited from protocols get the USR of the protocol
+  // symbol, regardless of which class it's actually appearing on. To prevent
+  // multiple of these symbols colliding with each other, treat them as
+  // synthesized symbols and use their parent type as the base type.
+  if (VD->isImplicit() && VD->hasClangNode() &&
+      VD->getClangNode().getAsDecl()) {
+    if (const auto *Parent =
+            dyn_cast_or_null<NominalTypeDecl>(VD->getDeclContext())) {
+      SG->recordNode(Symbol(SG, VD, Parent));
+      return true;
+    }
+  }
+
   // Otherwise, record this in the main module `M`'s symbol graph.
   SG->recordNode(Symbol(SG, VD, nullptr));
 

test/SymbolGraph/ClangImporter/Inputs/ObjcSynthesis/ObjcSynthesis.framework/Headers/ObjcSynthesis.h

@@ -0,0 +1,9 @@
+@import Foundation;
+
+@interface MyClassA : NSObject <NSCoding>
+
+@end
+
+@interface MyClassB : NSObject <NSCoding>
+
+@end

test/SymbolGraph/ClangImporter/Inputs/ObjcSynthesis/ObjcSynthesis.framework/Modules/ObjcSynthesis.swiftmodule/.keep

@@ -0,0 +1,4 @@
+framework module ObjcSynthesis {
+  header "ObjcSynthesis.h"
+  export *
+}

test/SymbolGraph/ClangImporter/Inputs/ObjcSynthesis/ObjcSynthesis.framework/ObjcSynthesis

@@ -0,0 +1,9 @@
+// RUN: %empty-directory(%t)
+// RUN: cp -r %S/Inputs/ObjcSynthesis/ObjcSynthesis.framework %t
+// RUN: %target-swift-frontend(mock-sdk: %clang-importer-sdk) -enable-objc-interop -emit-module -o %t/ObjcSynthesis.framework/Modules/ObjcSynthesis.swiftmodule/%target-swiftmodule-name -import-underlying-module -F %t -module-name ObjcSynthesis -disable-objc-attr-requires-foundation-module %s
+// RUN: %target-swift-symbolgraph-extract -sdk %clang-importer-sdk -module-name ObjcSynthesis -F %t -output-dir %t -pretty-print -v
+// RUN: %FileCheck %s --input-file %t/ObjcSynthesis.symbols.json
+
+// REQUIRES: objc_interop
+
+// CHECK-NOT: "precise": "c:objc(pl)NSCoding(im)initWithCoder"