ClangImporter: Remove some unnecessary (void) getInterfaceType() calls

Author: slavapestov

lib/ClangImporter/ImportDecl.cpp

@@ -540,8 +540,6 @@ makeEnumRawValueConstructor(ClangImporter::Implementation &Impl,
                             /*GenericParams=*/nullptr, enumDecl);
   ctorDecl->setImplicit();
   ctorDecl->setAccess(AccessLevel::Public);
-
-  (void)ctorDecl->getInterfaceType();
   ctorDecl->setBodySynthesizer(synthesizeEnumRawValueConstructorBody, enumDecl);
   return ctorDecl;
 }
@@ -617,8 +615,6 @@ static void makeEnumRawValueGetter(ClangImporter::Implementation &Impl,
   getterDecl->setIsDynamic(false);
   getterDecl->setIsTransparent(false);
 
-  (void)getterDecl->getInterfaceType();
-
   getterDecl->setAccess(AccessLevel::Public);
   getterDecl->setBodySynthesizer(synthesizeEnumRawValueGetterBody, enumDecl);
   makeComputed(rawValueDecl, getterDecl, nullptr);
@@ -698,8 +694,6 @@ static AccessorDecl *makeStructRawValueGetter(
   getterDecl->setIsDynamic(false);
   getterDecl->setIsTransparent(false);
 
-  (void)getterDecl->getInterfaceType();
-
   getterDecl->setAccess(AccessLevel::Public);
   getterDecl->setBodySynthesizer(synthesizeStructRawValueGetterBody, storedVar);
   return getterDecl;
@@ -729,8 +723,6 @@ static AccessorDecl *makeFieldGetterDecl(ClangImporter::Implementation &Impl,
   getterDecl->setIsObjC(false);
   getterDecl->setIsDynamic(false);
 
-  (void)getterDecl->getInterfaceType();
-
   return getterDecl;
 }
 
@@ -765,8 +757,6 @@ static AccessorDecl *makeFieldSetterDecl(ClangImporter::Implementation &Impl,
   setterDecl->setSelfAccessKind(SelfAccessKind::Mutating);
   setterDecl->setAccess(AccessLevel::Public);
 
-  (void)setterDecl->getInterfaceType();
-
   return setterDecl;
 }
 
@@ -1308,9 +1298,6 @@ createDefaultConstructor(ClangImporter::Implementation &Impl,
       /*Throws=*/false, /*ThrowsLoc=*/SourceLoc(), emptyPL,
       /*GenericParams=*/nullptr, structDecl);
 
-  // Set the constructor's type.
-  (void)constructor->getInterfaceType();
-
   constructor->setAccess(AccessLevel::Public);
 
   // Mark the constructor transparent so that we inline it away completely.
@@ -1437,9 +1424,6 @@ createValueConstructor(ClangImporter::Implementation &Impl,
       /*Throws=*/false, /*ThrowsLoc=*/SourceLoc(), paramList,
       /*GenericParams=*/nullptr, structDecl);
 
-  // Set the constructor's type.
-  (void)constructor->getInterfaceType();
-
   constructor->setAccess(AccessLevel::Public);
 
   // Make the constructor transparent so we inline it away completely.
@@ -1714,8 +1698,6 @@ buildSubscriptGetterDecl(ClangImporter::Implementation &Impl,
                      TypeLoc::withoutLoc(elementTy), dc,
                      getter->getClangNode());
 
-  (void)thunk->getInterfaceType();
-
   thunk->setAccess(getOverridableAccessLevel(dc));
 
   if (auto objcAttr = getter->getAttrs().getAttribute<ObjCAttr>())
@@ -1767,7 +1749,6 @@ buildSubscriptSetterDecl(ClangImporter::Implementation &Impl,
                      valueIndicesPL,
                      TypeLoc::withoutLoc(TupleType::getEmpty(C)), dc,
                      setter->getClangNode());
-  (void)thunk->getInterfaceType();
 
   thunk->setAccess(getOverridableAccessLevel(dc));
 
@@ -1952,7 +1933,6 @@ static bool addErrorDomain(NominalTypeDecl *swiftDecl,
                      /*GenericParams=*/nullptr,
                      params,
                      TypeLoc::withoutLoc(stringTy), swiftDecl);
-  (void)getterDecl->getInterfaceType();
   getterDecl->setIsObjC(false);
   getterDecl->setIsDynamic(false);
   getterDecl->setIsTransparent(false);
@@ -3733,7 +3713,6 @@ namespace {
 
       result->setIsObjC(false);
       result->setIsDynamic(false);
-      (void)result->getInterfaceType();
 
       Impl.recordImplicitUnwrapForDecl(result,
                                        importedType.isImplicitlyUnwrapped());
@@ -4316,9 +4295,6 @@ namespace {
       if (forceClassMethod)
         result->setImplicit();
 
-      // Compute the interface type.
-      (void)result->getInterfaceType();
-
       Impl.recordImplicitUnwrapForDecl(result, isIUO);
 
       // Mark this method @objc.
@@ -5855,8 +5831,6 @@ Decl *SwiftDeclConverter::importGlobalAsInitializer(
                                                 std::move(initKind));
   result->setImportAsStaticMember();
 
-  // Set the constructor's type.
-  (void)result->getInterfaceType();
   Impl.recordImplicitUnwrapForDecl(result,
                                    importedType.isImplicitlyUnwrapped());
   result->setOverriddenDecls({ });
@@ -6335,9 +6309,6 @@ ConstructorDecl *SwiftDeclConverter::importConstructor(
 
   addObjCAttribute(result, selector);
 
-  // Calculate the function type of the result.
-  (void)result->getInterfaceType();
-
   Impl.recordImplicitUnwrapForDecl(result,
                                    importedType.isImplicitlyUnwrapped());
 
@@ -8378,7 +8349,6 @@ ClangImporter::Implementation::createConstant(Identifier name, DeclContext *dc,
                      params,
                      TypeLoc::withoutLoc(type), dc);
   func->setStatic(isStatic);
-  (void)func->getInterfaceType();
   func->setAccess(getOverridableAccessLevel(dc));
   func->setIsObjC(false);
   func->setIsDynamic(false);