Merge pull request #755 from frootloops/bool

Simplifying the Bool creation with NSNumber

Author: gribozavr

stdlib/public/SDK/Foundation/Foundation.swift

@@ -313,8 +313,7 @@ extension Bool: _ObjectiveCBridgeable {
   }
 
   public init(_ number: NSNumber) {
-    if number.boolValue { self = true }
-    else { self = false }
+    self = number.boolValue
   }
 
   public static func _getObjectiveCType() -> Any.Type {

test/1_stdlib/BoolBridge.swift

@@ -0,0 +1,16 @@
+// RUN: %target-run-simple-swift
+// REQUIRES: executable_test
+// REQUIRES: objc_interop
+
+import Foundation
+import StdlibUnittest
+
+let BoolTests = TestSuite("Bool")
+
+BoolTests.test("Init with NSNumber") {
+  expectFalse(Bool(NSNumber(integerLiteral: 0)))
+  expectTrue(Bool(NSNumber(integerLiteral: 1)))
+  expectTrue(Bool(NSNumber(integerLiteral: 2)))
+}
+
+runAllTests()